From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95355C17444 for ; Sun, 10 Nov 2019 11:39:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B0A820B7C for ; Sun, 10 Nov 2019 11:39:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OJlfCWT8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B0A820B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pRQfS79gYx/rwTo5MrAT16RdIc7m6dup/JBnbPJmn0g=; b=OJlfCWT8WfZ+hF RSzHQw5/myCAEIFfPIZ5XioVWMGp3e1r7sAnJsaWhXFd9D6U+0ETToyKdc2OJC1/GytmU0DkmXmXF GaYEzYHyv/sIxv8oG0nj2BpeRIBjo4kMXwNmsEqFiNZ0TGNrmZZZN+j+PGPLnLv75/z/gp6mv0Ucc mLg0bkFGkwvjpFWzNfRaybuaixdDnG4Q/UiQu+nAxrUU6qBmkPRLX49XP3KYg3aD1tgbFN6y+5J5X 0AeuVOku2P94BpF8NfFlelS+xYr7P3PjIiuz0jbSqLZ6W9tOUeUCNS//kvc/Bn/r2YfOgOZ2f2Pe8 X0vayOHeq2CCRvHoI4sw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTlZ2-0004bE-DR; Sun, 10 Nov 2019 11:39:28 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTlYy-0004a7-5X; Sun, 10 Nov 2019 11:39:25 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 716C828DA46; Sun, 10 Nov 2019 11:39:22 +0000 (GMT) Date: Sun, 10 Nov 2019 12:39:19 +0100 From: Boris Brezillon To: Greg KH Subject: Re: [PATCH] mtd: rawnand: driver for Mediatek MT7621 SoC NAND flash controller Message-ID: <20191110123919.5c998839@collabora.com> In-Reply-To: <20191107084007.GA1203521@kroah.com> References: <20191107073521.11413-1-gerg@kernel.org> <20191107084007.GA1203521@kroah.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191110_033924_340165_5AD04984 X-CRM114-Status: GOOD ( 22.61 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, gerg@kernel.org, linux-mtd@lists.infradead.org, neil@brown.name, linux-mediatek@lists.infradead.org, blogic@openwrt.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, 7 Nov 2019 09:40:07 +0100 Greg KH wrote: > On Thu, Nov 07, 2019 at 05:35:21PM +1000, gerg@kernel.org wrote: > > From: Greg Ungerer > > > > Add a driver to support the NAND flash controller of the MediaTek MT7621 > > System-on-Chip device. (This one is the MIPS based parts from Mediatek). > > > > This code is a re-working of the earlier patches for this hardware that > > have been floating around the internet for years: > > > > https://github.com/ReclaimYourPrivacy/cloak/blob/master/target/linux/ramips/patches-3.18/0045-mtd-add-mt7621-nand-support.patch > > > > This is a much cleaned up version, put in staging to start with. > > It does still have some problems, mainly that it still uses a lot of the > > mtd raw nand legacy support. > > Is that an issue? Well, yes that's an issue since we decided that all new drivers should implement ->exec_op() instead of the legacy hooks. But that would be an issue even if we were merging the driver in staging. > Why not just put it in the "real" part of the kernel > then, if those apis are still in use? > > > The driver not only compiles, but it works well on the small range of > > hardware platforms that it has been used on so far. I have been using > > for quite a while now, cleaning up as I get time. > > > > So... I am looking for comments on the best approach forward with this. > > At least in staging it can get some more eyeballs going over it. > > staging will just nit-pick it to death for coding style issues, it's not > going to be get any major api changes/cleanups there usually. I'd > recommend just merging this to the "real" part of the kernel now if it's > working for you. I agree on that point: we should merge this driver directly in the NAND framework after it's been reworked to implement ->exec_op() instead of the legacy hooks. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/