From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28535C43331 for ; Sun, 10 Nov 2019 15:33:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC54220842 for ; Sun, 10 Nov 2019 15:33:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JdGnBISN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC54220842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigma-star.at Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R7i3daAtqK3mCUjRrtvgdhPTlxzeXN/vXlIKlkVUGUM=; b=JdGnBISN+MI4R4 VoF8Urh5Yj/yPsM682kWSMoJveGrgeJmtqfpihHX/R41y7jQvEyDAHpvO4CPMmk0wkmOcicJm78s7 6vl3rVYxkYGV9cu4f9bZ1BmHITeX2ZlC8DT+S9/92U90v9nOr92W66WfblwiyTOK4KIVMgy5EX5Qw wp0mff7UElrJBql/fI50AqG93JGS8dIjAFhHOUO54yM7NYW7P/SCG38WKX2cWr+tXNtAlA+zuatMI MRNqNrI9NeggjmcIdx7XUKKYe/fFMg6EDQC14yc9IGHn5bN26kzCDyILq/xiArHJuVwfpDT3eu5C3 lF6kCTY8n+ah1jveRLdg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTpDk-000737-Ox; Sun, 10 Nov 2019 15:33:44 +0000 Received: from lilium.sigma-star.at ([109.75.188.150]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTpCG-0005Zd-32 for linux-mtd@lists.infradead.org; Sun, 10 Nov 2019 15:32:13 +0000 Received: from localhost (localhost [127.0.0.1]) by lilium.sigma-star.at (Postfix) with ESMTP id 71EF718109A06; Sun, 10 Nov 2019 16:32:08 +0100 (CET) Received: from lilium.sigma-star.at ([127.0.0.1]) by localhost (lilium.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ZDLT_qQfoQ3h; Sun, 10 Nov 2019 16:32:07 +0100 (CET) Received: from lilium.sigma-star.at ([127.0.0.1]) by localhost (lilium.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Jgweu-HiGX3O; Sun, 10 Nov 2019 16:32:07 +0100 (CET) From: David Oberhollenzer To: linux-mtd@lists.infradead.org Subject: [PATCH 07/15] mkfs.jffs2: don't leak temporary buffer if readlink fails Date: Sun, 10 Nov 2019 16:30:51 +0100 Message-Id: <20191110153059.28878-8-david.oberhollenzer@sigma-star.at> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191110153059.28878-1-david.oberhollenzer@sigma-star.at> References: <20191110153059.28878-1-david.oberhollenzer@sigma-star.at> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191110_073212_300683_3E438AD1 X-CRM114-Status: UNSURE ( 8.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: richard@nod.at, David Oberhollenzer Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Signed-off-by: David Oberhollenzer --- jffsX-utils/mkfs.jffs2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/jffsX-utils/mkfs.jffs2.c b/jffsX-utils/mkfs.jffs2.c index 0661786..f46cc22 100644 --- a/jffsX-utils/mkfs.jffs2.c +++ b/jffsX-utils/mkfs.jffs2.c @@ -151,6 +151,7 @@ static char *xreadlink(const char *path) readsize = readlink(path, buf, bufsize); /* 1st try */ if (readsize == -1) { sys_errmsg("%s:%s", PROGRAM_NAME, path); + free(buf); return NULL; } } -- 2.21.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/