From: Sascha Hauer <s.hauer@pengutronix.de>
To: Hou Tao <houtao1@huawei.com>
Cc: richard@nod.at, linux-mtd@lists.infradead.org, vigneshr@ti.com,
miquel.raynal@bootlin.com
Subject: Re: [PATCH] UBI: Fastmap: free unused fastmap anchor peb during detach
Date: Mon, 6 Jan 2020 10:02:15 +0100 [thread overview]
Message-ID: <20200106090215.q346oxb532bhypnu@pengutronix.de> (raw)
In-Reply-To: <20191220021449.120639-1-houtao1@huawei.com>
On Fri, Dec 20, 2019 at 10:14:49AM +0800, Hou Tao wrote:
> When CONFIG_MTD_UBI_FASTMAP is enabled, fm_anchor will be assigned
> a free PEB during ubi_wl_init() or ubi_update_fastmap(). However
> if fastmap is not used or disabled on the MTD device, ubi_wl_entry
> related with the PEB will not be freed during detach.
>
> So Fix it by freeing the unused fastmap anchor during detach.
>
> And also don't generate the initial fm_anchor when fastmap is disabled.
I think this part deserves an extra patch. Otherwise the changes look
good to me, so:
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-06 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-08 19:35 memory leak in erase_aeb syzbot
2019-12-20 2:14 ` [PATCH] UBI: Fastmap: free unused fastmap anchor peb during detach Hou Tao
2020-01-06 9:02 ` Sascha Hauer [this message]
2020-01-12 22:51 ` Richard Weinberger
2020-01-11 17:19 ` memory leak in erase_aeb syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106090215.q346oxb532bhypnu@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=houtao1@huawei.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).