From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Marek Vasut <marex@denx.de>, Richard Weinberger <richard@nod.at>,
linux-mtd <linux-mtd@lists.infradead.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>
Subject: Re: [PATCH V2] mtd: rawnand: denali_dt: Add support for configuring SPARE_AREA_SKIP_BYTES
Date: Thu, 9 Jan 2020 17:13:37 +0100 [thread overview]
Message-ID: <20200109171337.2c0cc213@xps13> (raw)
In-Reply-To: <CAK7LNARkwtNsRrmq=9Cv+hgM2b68m7_2sV1mnrLuYuZ6H4j=vA@mail.gmail.com>
Hi Masahiro,
Masahiro Yamada <masahiroy@kernel.org> wrote on Fri, 10 Jan 2020
01:06:20 +0900:
> On Fri, Dec 20, 2019 at 6:39 PM Marek Vasut <marex@denx.de> wrote:
> >
> > The SPARE_AREA_SKIP_BYTES register is reset when the controller reset
> > signal is toggled. Yet, this register must be configured to match the
> > content of the NAND OOB area. The current default value is always set
> > to 8 and is programmed into the hardware in case the hardware was not
> > programmed before (e.g. in a bootloader) with a different value. This
> > however does not work when the block is reset properly by Linux.
> >
> > On Altera SoCFPGA CycloneV, ArriaV and Arria10, which are the SoCFPGA
> > platforms which support booting from NAND, the SPARE_AREA_SKIP_BYTES
> > value must be set to 2. On Socionext Uniphier, the value is 8. This
> > patch adds support for preconfiguring the default value and handles
> > the special SoCFPGA case by setting the default to 2 on all SoCFPGA
> > platforms, while retaining the original behavior and default value of
> > 8 on all the other platforms.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> > Cc: Richard Weinberger <richard@nod.at>
> > Cc: Vignesh Raghavendra <vigneshr@ti.com>
> > To: linux-mtd@lists.infradead.org
> > Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> > ---
> > V2: Move denali->oob_skip_bytes = data->oob_skip_bytes; right after
> > of_device_get_match_data()
>
>
> FYI.
>
> This patch was rebased to avoid a conflict:
> http://patchwork.ozlabs.org/patch/1214018/
>
> My Ack is in v3.
It is indeed about to be applied :)
Cheers,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-01-09 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 9:39 [PATCH V2] mtd: rawnand: denali_dt: Add support for configuring SPARE_AREA_SKIP_BYTES Marek Vasut
2020-01-09 16:06 ` Masahiro Yamada
2020-01-09 16:13 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109171337.2c0cc213@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=masahiroy@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).