From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
heiko@sntech.de, richard@nod.at, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
linux-arm-kernel@lists.infradead.org, vigneshr@ti.com
Subject: Re: [RFC PATCH v1 01/10] dt-bindings: mtd: add rockchip nand controller bindings
Date: Tue, 14 Jan 2020 19:57:06 -0600 [thread overview]
Message-ID: <20200115015706.GA30647@bogus> (raw)
In-Reply-To: <20200108205338.11369-2-jbx6244@gmail.com>
On Wed, Jan 08, 2020 at 09:53:29PM +0100, Johan Jonker wrote:
> Add the Rockchip NAND controller bindings.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> .../devicetree/bindings/mtd/rockchip,nandc.yaml | 78 ++++++++++++++++++++++
> 1 file changed, 78 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nandc.yaml
>
> diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nandc.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nandc.yaml
> new file mode 100644
> index 000000000..573d1a580
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/rockchip,nandc.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: GPL-2.0
Dual license new bindings:
(GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/rockchip,nandc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip NAND Controller Device Tree Bindings
> +
> +allOf:
> + - $ref: "nand-controller.yaml"
Should end with a '#'.
> +
> +maintainers:
> + - Heiko Stuebner <heiko@sntech.de>
> +
> +properties:
> + compatible:
> + enum:
> + - rockchip,nandc-v6
> + - rockchip,nandc-v9
Use SoC specific compatibles, not version numbers.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + oneOf:
> + - items:
> + - const: hclk_nandc
> + - items:
> + - const: clk_nandc
> + - const: hclk_nandc
Can't you put hclk_nandc first so it's always index 0.
> +
> +patternProperties:
> + "^nand@[a-f0-9]+$":
> + type: object
> + properties:
> + reg:
> + minimum: 0
> + maximum: 3
> +
> + nand-is-boot-medium: true
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/rk3188-cru-common.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + nandc: nand-controller@10500000 {
> + compatible = "rockchip,nandc-v6";
> + reg = <0x10500000 0x4000>;
> + interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_NANDC0>;
> + clock-names = "hclk_nandc";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + nand@0 {
> + reg = <0>;
> + nand-is-boot-medium;
> + };
> + };
> +
> +...
> --
> 2.11.0
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-15 1:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 20:53 [RFC PATCH v1 00/10] Enable RK3066 NANDC for MK808 Johan Jonker
2020-01-08 20:53 ` [RFC PATCH v1 01/10] dt-bindings: mtd: add rockchip nand controller bindings Johan Jonker
2020-01-15 1:57 ` Rob Herring [this message]
2020-01-08 20:53 ` [RFC PATCH v1 02/10] mtd: nand: raw: add rockchip nand controller driver Johan Jonker
2020-01-10 11:05 ` Miquel Raynal
2020-01-12 17:26 ` Johan Jonker
2020-01-13 14:15 ` Miquel Raynal
2020-01-08 20:53 ` [RFC PATCH v1 03/10] ARM: dts: rockchip: add nandc node for rk3066a/rk3188 Johan Jonker
2020-01-08 20:53 ` [RFC PATCH v1 04/10] ARM: dts: rockchip: add nandc node for rk322x Johan Jonker
2020-01-08 20:53 ` [RFC PATCH v1 05/10] ARM: dts: rockchip: add nandc nodes for rk3288 Johan Jonker
2020-01-08 20:53 ` [RFC PATCH v1 06/10] ARM: dts: rockchip: add nandc node for rv1108 Johan Jonker
2020-01-08 20:53 ` [RFC PATCH v1 07/10] arm64: dts: rockchip: add nandc node for px30 Johan Jonker
2020-01-08 20:53 ` [RFC PATCH v1 08/10] arm64: dts: rockchip: add nandc node for rk3308 Johan Jonker
2020-01-08 20:53 ` [RFC PATCH v1 09/10] arm64: dts: rockchip: add nandc node for rk3368 Johan Jonker
2020-01-08 20:53 ` [RFC PATCH v1 10/10] ARM: dts: rockchip: rk3066a-mk808: enable nandc node Johan Jonker
2020-01-13 1:55 ` [RFC PATCH v1 00/10] Enable RK3066 NANDC for MK808【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】 Shawn Lin
2020-01-13 18:33 ` Johan Jonker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115015706.GA30647@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).