From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84351C33CB3 for ; Thu, 16 Jan 2020 09:13:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 372E720748 for ; Thu, 16 Jan 2020 09:13:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NlD+h0uJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 372E720748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zr6vfgG/rb/Panxlsrf6L/hxVoBOWDQvBUiRJic5lTs=; b=NlD+h0uJ7v5Tiq gv7UhTPIDlDXuAnEGRNgIXZOyYQ8hlww/q4f4rnvuTWfT7gGCeY6yOAL+5INQcBGMVZw8YonzH7a/ p8US9g+YdyQjR52KJtABPUe6xiIPoz5hBz36eGwQXEH+TldSSfxL26IBhKiQRgI6yoDn+DMUZQSHe 84Tm9SFAc8+Krs7h6vFAbAQdG3HAAWZWpL9IOdU9bR4U+ZO6MZVzBaHYZUFEHE9QG10PlIW9E+Y4L bVaWPrjhL0lJS2n+KqQRxmEYQouLVAKqDlBW4dGFnIV0yNTEv6f3Wq4HjPqGhp4b2x074WPkIiGPe 6mnpFxS3u73IG7HAynKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1is1DK-0000Nr-RV; Thu, 16 Jan 2020 09:13:18 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1is1D1-0008SK-V1; Thu, 16 Jan 2020 09:13:03 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id B17B52938DB; Thu, 16 Jan 2020 09:12:51 +0000 (GMT) Date: Thu, 16 Jan 2020 10:12:49 +0100 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v3 12/40] mtd: nand: Rename a core structure Message-ID: <20200116101249.08f0da5e@collabora.com> In-Reply-To: <20200116095301.14c191ac@xps13> References: <20190919193141.7865-1-miquel.raynal@bootlin.com> <20190919193141.7865-13-miquel.raynal@bootlin.com> <20191012113530.6fe78c71@dhcp-172-31-174-146.wireless.concordia.ca> <20200116095301.14c191ac@xps13> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200116_011300_136776_83B400F7 X-CRM114-Status: GOOD ( 20.42 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mason Yang , Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , Schrempf Frieder , Paul Cercueil , Marek Vasut , linux-mtd@lists.infradead.org, Thomas Petazzoni , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, 16 Jan 2020 09:53:01 +0100 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Sat, 12 Oct > 2019 11:35:30 +0200: > > > On Thu, 19 Sep 2019 21:31:12 +0200 > > Miquel Raynal wrote: > > > > > Prepare the migration to a generic ECC engine by renaming the > > > nand_ecc_req structure into nand_ecc_props. This structure will be the > > > base of a wider 'nand_ecc' structure. > > > > > > Signed-off-by: Miquel Raynal > > > --- > > > include/linux/mtd/nand.h | 8 ++++---- > > > include/linux/mtd/spinand.h | 2 +- > > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > > > index 531c1799bf2c..7072f14239e5 100644 > > > --- a/include/linux/mtd/nand.h > > > +++ b/include/linux/mtd/nand.h > > > @@ -128,11 +128,11 @@ struct nand_page_io_req { > > > }; > > > > > > /** > > > - * struct nand_ecc_req - NAND ECC requirements > > > + * struct nand_ecc_props - NAND ECC properties > > > * @strength: ECC strength > > > - * @step_size: ECC step/block size > > > + * @step_size: Number of bytes per step > > > */ > > > -struct nand_ecc_req { > > > +struct nand_ecc_props { > > > unsigned int strength; > > > unsigned int step_size; > > > }; > > > @@ -191,7 +191,7 @@ struct nand_ops { > > > struct nand_device { > > > struct mtd_info mtd; > > > struct nand_memory_organization memorg; > > > - struct nand_ecc_req eccreq; > > > + struct nand_ecc_props eccreq; > > > > Let's rename this field too: s/eccreq/eccprops/ > > This is just a transition step, this field is being replaced by a much > wider structure two patches later. The impact of renaming this field is > huge compared to its interest so I'd prefer not to do it. Fair enough. I guess it's no longer named eccreq after the transition. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/