From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E501DC33C9E for ; Fri, 17 Jan 2020 21:44:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8EA42072B for ; Fri, 17 Jan 2020 21:44:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YUgH5Bi7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8EA42072B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0dxwG1LjNtERzboXz3zrJotrKLoHup+cZ94GtTaUMhk=; b=YUgH5Bi7iyhJjE P/Z8t6ey6ZmkrPpozAij08Ku0s3mdkbnxRm5r+sZgtofLMPZMxHU9IvtRLc6PILxHzp66hrBNClCF p7ksxMQxwIogah/TnOCY9vYVfD8SJL9cUPwbABoEGY6Rpyc/1A1yuL2WOVAmAW3UIntAz9TdPnClW Jg/ZaJjeoQV4/Z+m4wAxm7YCzYAYA4iWJjbUxk/LzAjgo5Os4TdPC/IP54CkSDzl7y/6mAy2DwtAY 9OeO9IgoJkEZ6vxXzbUYiiZhc4xD/k4Sm1+XQPZS04ycKYwvc/1PQ138nwAcCVLpf2XBxzfsienCf hfPYrF1acFx1Ij+wY4dg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1isZQ4-00030b-Vq; Fri, 17 Jan 2020 21:44:44 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1isZNl-0000n4-J4 for linux-mtd@lists.infradead.org; Fri, 17 Jan 2020 21:42:23 +0000 Received: from xps13.lan (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id C05B5240002; Fri, 17 Jan 2020 21:42:18 +0000 (UTC) From: Miquel Raynal To: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Subject: [PATCH v4 09/21] mtd: rawnand: Create a new enumeration to describe properly ECC types Date: Fri, 17 Jan 2020 22:41:39 +0100 Message-Id: <20200117214151.20767-10-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200117214151.20767-1-miquel.raynal@bootlin.com> References: <20200117214151.20767-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200117_134221_794976_3B64EFC3 X-CRM114-Status: UNSURE ( 9.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julien Su , Boris Brezillon , Mason Yang , Thomas Petazzoni , Miquel Raynal Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Now that the misleading mix between ECC engine type and OOB placement has been addressed, add a new enumeration to properly define ECC types (also called provider or mode). Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon --- drivers/mtd/nand/raw/nand_base.c | 7 +++++++ include/linux/mtd/rawnand.h | 16 ++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index 0fdc9d63f259..ddd886fb92c4 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -4775,6 +4775,13 @@ static const char * const nand_ecc_modes[] = { [NAND_ECC_ON_DIE] = "on-die", }; +static const char * const nand_ecc_engine_providers[] = { + [NAND_ECC_ENGINE_NONE] = "none", + [NAND_ECC_ENGINE_SOFT] = "soft", + [NAND_ECC_ENGINE_CONTROLLER] = "hw", + [NAND_ECC_ENGINE_ON_DIE] = "on-die", +}; + static const char * const nand_ecc_placement[] = { [NAND_ECC_PLACEMENT_INTERLEAVED] = "interleaved", }; diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h index 64de0015edbd..aeef31a68c7a 100644 --- a/include/linux/mtd/rawnand.h +++ b/include/linux/mtd/rawnand.h @@ -92,6 +92,22 @@ enum nand_ecc_mode { NAND_ECC_ON_DIE, }; +/** + * enum nand_ecc_engine_type - NAND ECC engine type/provider + * @NAND_ECC_ENGINE_INVALID: Invalid value + * @NAND_ECC_ENGINE_NONE: No ECC correction + * @NAND_ECC_ENGINE_SOFT: Software ECC correction + * @NAND_ECC_ENGINE_CONTROLLER: Hardware controller ECC correction + * @NAND_ECC_ENGINE_ON_DIE: On chip hardware ECC correction + */ +enum nand_ecc_engine_type { + NAND_ECC_ENGINE_INVALID, + NAND_ECC_ENGINE_NONE, + NAND_ECC_ENGINE_SOFT, + NAND_ECC_ENGINE_CONTROLLER, + NAND_ECC_ENGINE_ON_DIE, +}; + /** * enum nand_ecc_placement - NAND ECC placement * @NAND_ECC_PLACEMENT_FREE: The driver can decide where to put ECC bytes. -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/