From: kbuild test robot <lkp@intel.com>
To: WeiXiong Liao <liaoweixiong@allwinnertech.com>
Cc: Rob Herring <robh@kernel.org>, Tony Luck <tony.luck@intel.com>,
kbuild-all@lists.01.org, Kees Cook <keescook@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Anton Vorontsov <anton@enomsg.org>,
linux-doc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
WeiXiong Liao <liaoweixiong@allwinnertech.com>,
linux-mtd@lists.infradead.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Colin Cross <ccross@android.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 01/11] pstore/blk: new support logger for block devices
Date: Sat, 18 Jan 2020 20:42:33 +0800 [thread overview]
Message-ID: <202001182019.g3m9pK8B%lkp@intel.com> (raw)
In-Reply-To: <1579168831-16399-2-git-send-email-liaoweixiong@allwinnertech.com>
[-- Attachment #1: Type: text/plain, Size: 3370 bytes --]
Hi WeiXiong,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kees/for-next/pstore]
[also build test WARNING on ia64/next linus/master v5.5-rc6 next-20200117]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/WeiXiong-Liao/pstore-support-crash-log-to-block-and-mtd-device/20200117-152012
base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
fs//pstore/blkzone.c: In function 'blkz_zone_write':
>> fs//pstore/blkzone.c:190:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (wcnt != wlen)
^
fs//pstore/blkzone.c:192:2: note: here
case FLUSH_META:
^~~~
vim +190 fs//pstore/blkzone.c
156
157 static int blkz_zone_write(struct blkz_zone *zone,
158 enum blkz_flush_mode flush_mode, const char *buf,
159 size_t len, unsigned long off)
160 {
161 struct blkz_info *info = blkz_cxt.bzinfo;
162 ssize_t wcnt = 0;
163 ssize_t (*writeop)(const char *buf, size_t bytes, loff_t pos);
164 size_t wlen;
165
166 if (off > zone->buffer_size)
167 return -EINVAL;
168 wlen = min_t(size_t, len, zone->buffer_size - off);
169 if (buf && wlen) {
170 memcpy(zone->buffer->data + off, buf, wlen);
171 atomic_set(&zone->buffer->datalen, wlen + off);
172 }
173
174 /* avoid to damage old records */
175 if (!is_on_panic() && !atomic_read(&blkz_cxt.recovered))
176 goto set_dirty;
177
178 writeop = is_on_panic() ? info->panic_write : info->write;
179 if (!writeop)
180 goto set_dirty;
181
182 switch (flush_mode) {
183 case FLUSH_NONE:
184 if (unlikely(buf && wlen))
185 goto set_dirty;
186 return 0;
187 case FLUSH_PART:
188 wcnt = writeop((const char *)zone->buffer->data + off, wlen,
189 zone->off + sizeof(*zone->buffer) + off);
> 190 if (wcnt != wlen)
191 goto set_dirty;
192 case FLUSH_META:
193 wlen = sizeof(struct blkz_buffer);
194 wcnt = writeop((const char *)zone->buffer, wlen, zone->off);
195 if (wcnt != wlen)
196 goto set_dirty;
197 break;
198 case FLUSH_ALL:
199 wlen = zone->buffer_size + sizeof(*zone->buffer);
200 wcnt = writeop((const char *)zone->buffer, wlen, zone->off);
201 if (wcnt != wlen)
202 goto set_dirty;
203 break;
204 }
205
206 return 0;
207 set_dirty:
208 atomic_set(&zone->dirty, true);
209 return -EBUSY;
210 }
211
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52800 bytes --]
[-- Attachment #3: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-18 13:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 10:00 [PATCH 00/11] pstore: support crash log to block and mtd device WeiXiong Liao
2020-01-16 10:00 ` [PATCH 01/11] pstore/blk: new support logger for block devices WeiXiong Liao
2020-01-18 12:42 ` kbuild test robot [this message]
2020-01-16 10:00 ` [PATCH 02/11] blkoops: add blkoops, a warpper for pstore/blk WeiXiong Liao
2020-01-16 10:00 ` [PATCH 03/11] pstore/blk: support pmsg recorder WeiXiong Liao
2020-01-16 10:00 ` [PATCH 04/11] pstore/blk: blkoops: support console recorder WeiXiong Liao
2020-01-16 10:00 ` [PATCH 05/11] pstore/blk: blkoops: support ftrace recorder WeiXiong Liao
2020-01-16 10:00 ` [PATCH 06/11] Documentation: pstore/blk: blkoops: create document for pstore_blk WeiXiong Liao
2020-01-16 10:00 ` [PATCH 07/11] pstore/blk: skip broken zone for mtd device WeiXiong Liao
2020-01-16 10:00 ` [PATCH 08/11] blkoops: respect for device to pick recorders WeiXiong Liao
2020-01-16 10:00 ` [PATCH 09/11] pstore/blk: blkoops: support special removing jobs for dmesg WeiXiong Liao
2020-01-16 10:00 ` [PATCH 10/11] blkoops: add interface for dirver to get information of blkoops WeiXiong Liao
2020-01-16 10:00 ` [PATCH 11/11] mtd: new support oops logger based on pstore/blk WeiXiong Liao
2020-01-18 17:07 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001182019.g3m9pK8B%lkp@intel.com \
--to=lkp@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=liaoweixiong@allwinnertech.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mchehab+samsung@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).