linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Richard Weinberger <richard@nod.at>
Cc: linux-fscrypt <linux-fscrypt@vger.kernel.org>,
	Chandan Rajendra <chandan@linux.vnet.ibm.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH] ubifs: use IS_ENCRYPTED() instead of ubifs_crypt_is_encrypted()
Date: Mon, 20 Jan 2020 10:47:24 -0800	[thread overview]
Message-ID: <20200120184724.GA4118@sol.localdomain> (raw)
In-Reply-To: <397871241.24589.1579513469565.JavaMail.zimbra@nod.at>

On Mon, Jan 20, 2020 at 10:44:29AM +0100, Richard Weinberger wrote:
> 
> ----- Ursprüngliche Mail -----
> > Von: "Eric Biggers" <ebiggers@kernel.org>
> > An: "Richard Weinberger" <richard.weinberger@gmail.com>
> > CC: "richard" <richard@nod.at>, "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-fscrypt"
> > <linux-fscrypt@vger.kernel.org>, "Chandan Rajendra" <chandan@linux.vnet.ibm.com>
> > Gesendet: Montag, 20. Januar 2020 07:54:22
> > Betreff: Re: [PATCH] ubifs: use IS_ENCRYPTED() instead of ubifs_crypt_is_encrypted()
> 
> > On Thu, Jan 09, 2020 at 09:01:09AM +0100, Richard Weinberger wrote:
> >> On Fri, Jan 3, 2020 at 6:09 PM Eric Biggers <ebiggers@kernel.org> wrote:
> >> >
> >> > On Mon, Dec 09, 2019 at 01:27:21PM -0800, Eric Biggers wrote:
> >> > > From: Eric Biggers <ebiggers@google.com>
> >> > >
> >> > > There's no need for the ubifs_crypt_is_encrypted() function anymore.
> >> > > Just use IS_ENCRYPTED() instead, like ext4 and f2fs do.  IS_ENCRYPTED()
> >> > > checks the VFS-level flag instead of the UBIFS-specific flag, but it
> >> > > shouldn't change any behavior since the flags are kept in sync.
> >> > >
> >> > > Signed-off-by: Eric Biggers <ebiggers@google.com>
> >> > > ---
> >> > >  fs/ubifs/dir.c     | 8 ++++----
> >> > >  fs/ubifs/file.c    | 4 ++--
> >> > >  fs/ubifs/journal.c | 6 +++---
> >> > >  fs/ubifs/ubifs.h   | 7 -------
> >> > >  4 files changed, 9 insertions(+), 16 deletions(-)
> >> >
> >> > Richard, can you consider applying this to the UBIFS tree for 5.6?
> >> 
> >> Sure. I'm back from the x-mas break and start collecting patches.
> >> 
> > 
> > Ping?  I see the other UBIFS patches I sent in linux-ubifs.git#linux-next,
> > but not this one.
> 
> Oh dear, I reviewed but forgot to apply it. Now I'm already traveling without my
> kernel.org PGP keys.
> 
> The patch is simple and sane, so I'm totally fine if you carry it via fscrypt.
> Another option is that Miquel carries it via MTD this time.
> 
> In any case:
> 
> Acked-by: Richard Weinberger <richard@nod.at>
> 
> Sorry for messing this up. :-(
> 

I just went ahead and applied it to the fscrypt tree with your Acked-by, since
it doesn't conflict with anything in the UBIFS tree.  Thanks,

- Eric

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2020-01-20 18:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 21:27 [PATCH] ubifs: use IS_ENCRYPTED() instead of ubifs_crypt_is_encrypted() Eric Biggers
2020-01-03 17:09 ` Eric Biggers
2020-01-09  8:01   ` Richard Weinberger
2020-01-20  6:54     ` Eric Biggers
2020-01-20  9:44       ` Richard Weinberger
2020-01-20 18:47         ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200120184724.GA4118@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=chandan@linux.vnet.ibm.com \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).