From: Sascha Hauer <s.hauer@pengutronix.de>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jan Kara <jack@suse.cz>, Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org, kernel@pengutronix.de,
Jan Kara <jack@suse.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/8] quota: Allow to pass mount path to quotactl
Date: Tue, 4 Feb 2020 11:35:23 +0100 [thread overview]
Message-ID: <20200204103523.tbxzptf4lkr474yi@pengutronix.de> (raw)
In-Reply-To: <20200129012929.GV23230@ZenIV.linux.org.uk>
On Wed, Jan 29, 2020 at 01:29:29AM +0000, Al Viro wrote:
> On Tue, Jan 28, 2020 at 11:06:31AM +0100, Sascha Hauer wrote:
> > Hi Jan,
>
> > @@ -810,6 +811,36 @@ static struct super_block *quotactl_block(const char __user *special, int cmd)
> > #endif
> > }
> >
> > +static struct super_block *quotactl_path(const char __user *special, int cmd,
> > + struct path *path)
> > +{
> > + struct super_block *sb;
> > + int ret;
> > +
> > + ret = user_path_at(AT_FDCWD, special, LOOKUP_FOLLOW | LOOKUP_AUTOMOUNT,
> > + path);
> > + if (ret)
> > + return ERR_PTR(ret);
> > +
> > + sb = path->mnt->mnt_sb;
> > +restart:
> > + if (quotactl_cmd_onoff(cmd))
> > + down_write(&sb->s_umount);
> > + else
> > + down_read(&sb->s_umount);
> > +
> > + if (quotactl_cmd_write(cmd) && sb->s_writers.frozen != SB_UNFROZEN) {
> > + if (quotactl_cmd_onoff(cmd))
> > + up_write(&sb->s_umount);
> > + else
> > + up_read(&sb->s_umount);
> > + wait_event(sb->s_writers.wait_unfrozen,
> > + sb->s_writers.frozen == SB_UNFROZEN);
> > + goto restart;
> > + }
> > +
> > + return sb;
> > +}
>
> This partial duplicate of __get_super_thawed() guts does *not* belong here,
> especially not interleaved with quota-specific checks.
>
> > + if (q_path) {
> > + if (quotactl_cmd_onoff(cmd))
> > + up_write(&sb->s_umount);
> > + else
> > + up_read(&sb->s_umount);
> > +
> > + path_put(&sb_path);
> > + } else {
> > + if (!quotactl_cmd_onoff(cmds))
> > + drop_super(sb);
> > + else
> > + drop_super_exclusive(sb);
> > + }
>
> Er... Why not have the same code that you've used to lock the damn thing
> (needs to be moved to fs/super.c) simply get a passive ref to it? Then
> you could do the same thing, q_path or no q_path...
I am getting confused here. To an earlier version of this series you
responded:
> And for path-based you don't need to mess with superblock
> references - just keep the struct path until the end. That
> will keep the superblock alive and active just fine.
I did that and got the objection from Jan:
> So I've realized that just looking up superblock with user_path_at() is not
> enough. Quota code also expects that the superblock will be locked
> (sb->s_umount) and filesystem will not be frozen (in case the quota
> operation is going to modify the filesystem). This is needed to serialize
> e.g. remount and quota operations or quota operations among themselves.
So after drawing circles we now seem to be back at passive references.
What I have now in my tree is this in fs/super.c, untested currently:
static bool __grab_super_thawed(struct super_block *sb, bool excl)
{
while (1) {
bool again = false;
spin_lock(&sb_lock);
if (hlist_unhashed(&sb->s_instances)) {
spin_unlock(&sb_lock);
return false;
}
sb->s_count++;
spin_unlock(&sb_lock);
if (excl)
down_write(&sb->s_umount);
else
down_read(&sb->s_umount);
if (sb->s_root && (sb->s_flags & SB_BORN)) {
if (sb->s_writers.frozen == SB_UNFROZEN)
return true;
else
again = true;
}
if (excl)
up_write(&sb->s_umount);
else
up_read(&sb->s_umount);
if (again)
wait_event(sb->s_writers.wait_unfrozen,
sb->s_writers.frozen == SB_UNFROZEN);
put_super(sb);
if (!again)
return false;
}
return ret;
}
int grab_super_thawed(struct super_block *sb)
{
return __grab_super_thawed(sb, false);
}
int grab_super_exclusive_thawed(struct super_block *sb)
{
return __grab_super_thawed(sb, true);
}
Does this look ok now?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-02-04 10:35 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 13:13 [PATCH v4 0/8] Add quota support to UBIFS Sascha Hauer
2020-01-24 13:13 ` [PATCH 1/8] quota: Allow to pass mount path to quotactl Sascha Hauer
2020-01-27 10:45 ` Jan Kara
2020-01-28 10:06 ` Sascha Hauer
2020-01-28 11:41 ` Jan Kara
2020-01-29 1:29 ` Al Viro
2020-01-29 16:14 ` Jan Kara
2020-02-04 10:35 ` Sascha Hauer [this message]
2020-02-18 9:22 ` Jan Kara
2020-01-24 13:13 ` [PATCH 2/8] ubifs: move checks and preparation into setflags() Sascha Hauer
2020-01-24 13:13 ` [PATCH 3/8] ubifs: Add support for FS_IOC_FS[SG]ETXATTR ioctls Sascha Hauer
2020-01-24 13:13 ` [PATCH 4/8] ubifs: do not ubifs_inode() on potentially NULL pointer Sascha Hauer
2020-01-24 13:13 ` [PATCH 5/8] ubifs: Factor out ubifs_set_feature_flag() Sascha Hauer
2020-01-24 13:13 ` [PATCH 6/8] ubifs: Add support for project id Sascha Hauer
2020-01-24 13:13 ` [PATCH 7/8] ubifs: export get_znode Sascha Hauer
2020-01-24 13:13 ` [PATCH 8/8] ubifs: Add quota support Sascha Hauer
2020-01-26 18:30 ` kbuild test robot
2020-01-26 18:30 ` [RFC PATCH] ubifs: tnc_next() can be static kbuild test robot
2021-01-22 15:15 [PATCH v5 0/8] Add quota support to UBIFS Sascha Hauer
2021-01-22 15:15 ` [PATCH 1/8] quota: Allow to pass mount path to quotactl Sascha Hauer
2021-01-22 17:16 ` Christoph Hellwig
2021-01-25 8:38 ` Sascha Hauer
2021-01-25 15:45 ` Jan Kara
2021-01-25 20:42 ` Christoph Hellwig
2021-01-26 13:17 ` Jan Kara
2021-01-26 13:34 ` Christoph Hellwig
2021-01-26 16:18 ` Jan Kara
2021-01-27 14:05 ` Sascha Hauer
2021-01-27 14:19 ` Jan Kara
2021-01-26 10:45 ` Sascha Hauer
2021-01-27 14:46 ` Jan Kara
2021-01-27 16:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204103523.tbxzptf4lkr474yi@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=kernel@pengutronix.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).