From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Yoshio Furuyama <ytc-mb-yfuruyama7@kioxia.com>
Cc: linux-mtd@lists.infradead.org, vigneshr@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mtd: spinand: toshiba: Add comment about Kioxia ID
Date: Fri, 7 Feb 2020 09:32:34 +0100 [thread overview]
Message-ID: <20200207093234.56bd8cae@xps13> (raw)
In-Reply-To: <1581051561-7302-1-git-send-email-ytc-mb-yfuruyama7@kioxia.com>
Hi Yoshio,
Yoshio Furuyama <ytc-mb-yfuruyama7@kioxia.com> wrote on Fri, 7 Feb
2020 13:59:21 +0900:
> Add a comment above NAND_MFR_TOSHIBA and SPINAND_MFR_TOSHIBA definitions
> that Toshiba and Kioxia ID are the same.
> Since its independence from Toshiba Group, Toshiba memory Co has become
> Kioxia Co.
>
> Signed-off-by: Yoshio Furuyama <ytc-mb-yfuruyama7@kioxia.com>
Just as an FYI for your next submission, below the three dashes you
should add a changelog, a small paragraph describing what changed
between the versions.
No need to resend just for this, I have it in mind.
I'm fine with the patch and will apply it soon.
> ---
> drivers/mtd/nand/raw/internals.h | 1 +
> drivers/mtd/nand/spi/toshiba.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h
> index cba6fe7..9d0caad 100644
> --- a/drivers/mtd/nand/raw/internals.h
> +++ b/drivers/mtd/nand/raw/internals.h
> @@ -30,6 +30,7 @@
> #define NAND_MFR_SAMSUNG 0xec
> #define NAND_MFR_SANDISK 0x45
> #define NAND_MFR_STMICRO 0x20
> +/* Kioxia is new name of Toshiba memory. */
> #define NAND_MFR_TOSHIBA 0x98
> #define NAND_MFR_WINBOND 0xef
>
> diff --git a/drivers/mtd/nand/spi/toshiba.c b/drivers/mtd/nand/spi/toshiba.c
> index 0db5ee4..833e8f6 100644
> --- a/drivers/mtd/nand/spi/toshiba.c
> +++ b/drivers/mtd/nand/spi/toshiba.c
> @@ -10,6 +10,7 @@
> #include <linux/kernel.h>
> #include <linux/mtd/spinand.h>
>
> +/* Kioxia is new name of Toshiba memory. */
> #define SPINAND_MFR_TOSHIBA 0x98
> #define TOSH_STATUS_ECC_HAS_BITFLIPS_T (3 << 4)
>
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-02-07 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 4:59 [PATCH v3] mtd: spinand: toshiba: Add comment about Kioxia ID Yoshio Furuyama
2020-02-07 8:32 ` Miquel Raynal [this message]
2020-03-10 18:33 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207093234.56bd8cae@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vigneshr@ti.com \
--cc=ytc-mb-yfuruyama7@kioxia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).