From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45D04C3403A for ; Tue, 18 Feb 2020 12:56:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D7282067D for ; Tue, 18 Feb 2020 12:56:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jbNWfd4X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D7282067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gUE0PrYadqIKJx4YQ4GFykxr4g/aUnAJJ52YGW4iazk=; b=jbNWfd4XzboXkESxJuEw+NqxR Gakci3IUATuJfKGD1OBCeH+SoodrdWEJzCHu4L2zZF1Dui4ra3KuIaFGYI12xT4bza2jJ+xQ9ZiEN 6uTN5jCkpDrcBmwvyn4Y67PY8buiFfrws4DDvluMe6fEnMlmZeRt/euWkjKCIxb1xH0MqDlsaz0/3 lrZSoI3AhLxvsCLcFL26YpUTr/FBFDcT5Hs9Aqr32j0Lgt8/7Ie5neZCP/x+FUVjo7L1RvIbjI+8H cpQSrKmG33tYwsC6XqNNb19ikoNWB559APRdnmver3PGGH5nyT63S29K9E1T0nAClKRhmLgGybdud oXjBrbbPw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j42Q7-00069I-Bf; Tue, 18 Feb 2020 12:56:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j42Pw-0005wB-Kf; Tue, 18 Feb 2020 12:56:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 316511FB; Tue, 18 Feb 2020 04:55:59 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A616F3F703; Tue, 18 Feb 2020 04:55:58 -0800 (PST) Date: Tue, 18 Feb 2020 12:55:57 +0000 From: Mark Brown To: Chuanhong Guo Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem Message-ID: <20200218125557.GD4232@sirena.org.uk> References: <20200215065826.739102-1-gch981213@gmail.com> MIME-Version: 1.0 In-Reply-To: <20200215065826.739102-1-gch981213@gmail.com> X-Cookie: No alcohol, dogs or horses. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200218_045600_723353_7DF0977D X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Richard Weinberger , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, Miquel Raynal , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0654625222912848255==" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org --===============0654625222912848255== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/3yNEOqWowh/8j+e" Content-Disposition: inline --/3yNEOqWowh/8j+e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Feb 15, 2020 at 02:58:24PM +0800, Chuanhong Guo wrote: > To keep patchset small for easier reviewing, there will be 3 patchsets > including this one. > 1. add the new driver, which is this patchset. > 2. update existing dts for the new driver: > spi-max-frequency is missing in current mtk-quadspi binding. Old > driver parses child node manually so it doesn't need this, but > new spi-mem driver is probed via spi subsystem which requires the > presence of spi-max-frequency. Since this doesn't break old driver > support, I'll send this separately as a standalone patch. This is an ABI break so you shouldn't be doing this, if the existing binding works it should continue to work. > 3. removing the old driver. I'll create this commit after 1 and 2 are > applied to avoid possible rebasing due to any changes in the old > driver. This isn't great as it means we have a period with two drivers for the same thing in tree which is at best going to be confusing. There's no advantage to splitting this out. --/3yNEOqWowh/8j+e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5L3twACgkQJNaLcl1U h9CQ0Af/bCSGtGQh9O/SezBLGjZ59DSJjcG/kJ2CB/e5Ub3WkveUKq3prcIpbWRZ j7LZ1+3P0+IQJC2b4wWFTf6xOOoucP4Qb1qVBc1HyBt9SrqrrZ3SdEXzhbsYJ1Zq tLGrQ37qdRhfSpspLm1N3FN+EBZuVW3tYPclxUjkHTE50mu0wmMAk4OXtrbyBKp7 H046klgqVPBXzTlP8mFTtp0/E/hYhrBUTqcEcUBTAw3nCMBMiVxUjdxRx+tB41CR TBBlM9+VwbxRbrzZC9IL5S+l+Bi9EW2axbZ2zFG7vOTc+AoCIT/PxwyZBshr8Xoh A7hM2b6D+BSbpRcPwjpZLi3E11d0ug== =CyQ7 -----END PGP SIGNATURE----- --/3yNEOqWowh/8j+e-- --===============0654625222912848255== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ --===============0654625222912848255==--