From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: vigneshr@ti.com, bbrezillon@kernel.org, juliensu@mxic.com.tw,
richard@nod.at, s.hauer@pengutronix.de, yuehaibing@huawei.com,
linux-kernel@vger.kernel.org, frieder.schrempf@kontron.de,
rfontana@redhat.com, linux-mtd@lists.infradead.org,
stefan@agner.ch, tglx@linutronix.de, masonccyang@mxic.com.tw,
allison@lohutok.net
Subject: Re: [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation
Date: Wed, 11 Mar 2020 08:56:42 +0100 [thread overview]
Message-ID: <20200311085642.36d91673@collabora.com> (raw)
In-Reply-To: <20200311084304.580bec79@xps13>
On Wed, 11 Mar 2020 08:43:04 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi Mason,
>
> masonccyang@mxic.com.tw wrote on Wed, 11 Mar 2020 13:40:52 +0800:
>
> > Hi Boris,
> >
> > > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> > > > index bc2fa3c..c0055ed 100644
> > > > --- a/include/linux/mtd/rawnand.h
> > > > +++ b/include/linux/mtd/rawnand.h
> > > > @@ -1064,6 +1064,8 @@ struct nand_legacy {
> > > > * @lock: lock protecting the suspended field. Also used to
> > > > * serialize accesses to the NAND device.
> > > > * @suspended: set to 1 when the device is suspended, 0 when
> > it's not.
> > > > + * @_suspend: [REPLACEABLE] specific NAND device suspend
> > operation
> > > > + * @_resume: [REPLACEABLE] specific NAND device resume operation
> > > > * @bbt: [INTERN] bad block table pointer
> > > > * @bbt_td: [REPLACEABLE] bad block table descriptor for flash
> > > > * lookup.
> > > > @@ -1119,6 +1121,8 @@ struct nand_chip {
> > > >
> > > > struct mutex lock;
> > > > unsigned int suspended : 1;
> > > > + int (*_suspend)(struct nand_chip *chip);
> > > > + void (*_resume)(struct nand_chip *chip);
> > >
> > > I thought we agreed on not prefixing new hooks with _ ?
> >
> > For [PATCH v2] series, you mentioned to drop the _ prefix
> > of _lock/_unlock only and we finally patched to lock_area/unlock_area.
> >
>
> I missed this _, this is not something we want to add.
>
> Also, when applying your patches I had several issues because they
> where not base on the last -rc1.
>
> Finally, I think I forgot a line when patching manually so it produces
> a warning now.
>
> I am dropping patch 3 and 4, I keep patch 1 and 2 which seem fine.
>
> Please send a rebased and edited v4 for these, don't forget to drop the
> kbuildtest robot tag and please also follow these slightly edited
> commit logs:
>
> 2/4
>
> mtd: rawnand: Add support for manufacturer specific suspend/resume operation
>
> Patch nand_suspend() & nand_resume() to let manufacturers overwrite
> suspend/resume operations.
>
> 3/4
>
> mtd: rawnand: macronix: Add support for deep power down mode
>
> Macronix AD series support deep power down mode for a minimum
> power consumption state.
>
> Overlaod nand_suspend() & nand_resume() in Macronix specific code to
> support deep power down mode.
And don't forget to propagate the ->suspend() error code to the upper
layer.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-03-11 7:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 7:21 [PATCH v3 0/4] mtd: rawnand: Add support Macronix Block Portection & Deep Power Down mode Mason Yang
2020-03-03 7:21 ` [PATCH v3 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operation Mason Yang
2020-03-10 18:30 ` Miquel Raynal
2020-03-10 19:27 ` Boris Brezillon
2020-03-11 2:40 ` masonccyang
2020-03-11 7:25 ` Miquel Raynal
2020-03-03 7:21 ` [PATCH v3 2/4] mtd: rawnand: Add support Macronix Block Protection function Mason Yang
2020-03-03 7:21 ` [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation Mason Yang
2020-03-10 18:30 ` Miquel Raynal
2020-03-10 19:33 ` Boris Brezillon
2020-03-11 5:40 ` masonccyang
2020-03-11 7:43 ` Miquel Raynal
2020-03-11 7:56 ` Boris Brezillon [this message]
2020-03-12 1:45 ` masonccyang
2020-03-10 19:39 ` Boris Brezillon
2020-03-10 19:41 ` Boris Brezillon
2020-03-11 6:13 ` masonccyang
2020-03-11 8:01 ` Boris Brezillon
2020-03-12 1:48 ` masonccyang
2020-03-03 7:21 ` [PATCH v3 4/4] mtd: rawnand: Add support Macronix deep power down mode Mason Yang
2020-03-09 13:14 ` [PATCH v3 0/4] mtd: rawnand: Add support Macronix Block Portection & Deep Power Down mode Miquel Raynal
2020-03-10 2:30 ` masonccyang
2020-03-10 7:44 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311085642.36d91673@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=allison@lohutok.net \
--cc=bbrezillon@kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=rfontana@redhat.com \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).