linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: <Tudor.Ambarus@microchip.com>
Cc: richard@nod.at, linux-mtd@lists.infradead.org, vigneshr@ti.com
Subject: Re: [PATCH v2] mtd: Convert fallthrough comments into statements
Date: Fri, 27 Mar 2020 09:53:23 +0100	[thread overview]
Message-ID: <20200327095323.2f0ea693@xps13> (raw)
In-Reply-To: <11409771.dsHhkDzkrP@192.168.0.120>

Hi Tudor,

<Tudor.Ambarus@microchip.com> wrote on Fri, 27 Mar 2020 08:43:52 +0000:

> On Wednesday, March 25, 2020 11:21:15 PM EET Miquel Raynal wrote:
> > --- a/drivers/mtd/spi-nor/sfdp.c
> > +++ b/drivers/mtd/spi-nor/sfdp.c
> > @@ -623,7 +623,6 @@ static u8 spi_nor_smpt_addr_width(const struct spi_nor
> > *nor, const u32 settings) case SMPT_CMD_ADDRESS_LEN_4:
> >                 return 4;
> >         case SMPT_CMD_ADDRESS_LEN_USE_CURRENT:
> > -               /* fall through */  
> 
> just noticed that you forgot the statement here.
> 
> >         default:
> >                 return nor->addr_width;
> >         }  
> 
> 
> 

I think this one is not needed, you don't need a fallthrough statement
when there are multiples case statements in a raw (default might be
seen as a case statement). So it was removed on purpose.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-03-27  8:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 21:21 [PATCH v2] mtd: Convert fallthrough comments into statements Miquel Raynal
2020-03-27  8:43 ` Tudor.Ambarus
2020-03-27  8:53   ` Miquel Raynal [this message]
2020-03-27 10:47     ` Tudor.Ambarus
2020-03-28 19:33 ` Richard Weinberger
2020-03-30  8:15 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200327095323.2f0ea693@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).