From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA26FC2BA1B for ; Sun, 5 Apr 2020 09:01:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D45A20675 for ; Sun, 5 Apr 2020 09:01:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZpEz5WW5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D45A20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bbKnMoEsqgcStHZcNHgNWEthZc0yBujztET0PwXz7Ts=; b=ZpEz5WW53EYEvS 7YqiJztjF4BRp+Ea0oPB1/sckEgVkMevkrMHuMVe2xwjenHCWAkQITzzXrONMiiA9f6ov60ZeUmRX I7taLH/Hjgnb5loFmDXrTBv2qMLdR5v09lKDx/zba8SKuWBLMvm6LxZZxdpz3ZDtQp7TTb75PxrXF kwsQv2IiFnPFRX05d/wnsfoTg3IJuduX4diDY6KXsb2J1wAqLTo3bTC7MeH781f75j4YZ8KmwEtsS WnURHli4Hq28ME3j8oiF9q92gNyZwMzlHol6vmDk091UiNRY0M+DsNo4P1UWWsl5BHkIDaV1xzJmu mwQNx0+qZoJr39ktnmmQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jL19Y-00039D-Gs; Sun, 05 Apr 2020 09:01:16 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jL19O-00032Y-Ap; Sun, 05 Apr 2020 09:01:08 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C8D85283C69; Sun, 5 Apr 2020 10:01:00 +0100 (BST) Date: Sun, 5 Apr 2020 11:00:56 +0200 From: Boris Brezillon To: Guenter Roeck Subject: Re: [PATCH v2 03/25] mtd: spi-nor: Prepare core / manufacturer code split Message-ID: <20200405110056.7764d64e@collabora.com> In-Reply-To: <20200404060015.GA209893@roeck-us.net> References: <20200313194130.342251-1-tudor.ambarus@microchip.com> <20200313194130.342251-4-tudor.ambarus@microchip.com> <20200404053936.GA176702@roeck-us.net> <20200404060015.GA209893@roeck-us.net> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200405_020106_532033_2C1A11BD X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, bbrezillon@kernel.org, richard@nod.at, Tudor.Ambarus@microchip.com, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, 3 Apr 2020 23:00:15 -0700 Guenter Roeck wrote: > On Fri, Apr 03, 2020 at 10:39:36PM -0700, Guenter Roeck wrote: > > On Fri, Mar 13, 2020 at 07:42:36PM +0000, Tudor.Ambarus@microchip.com wrote: > > > From: Boris Brezillon > > > > > > Move all SPI NOR controller drivers to a controllers/ sub-directory > > > so that we only have SPI NOR related source files under > > > drivers/mtd/spi-nor/. > > > > > > Rename spi-nor.c into core.c, we are about to split this file in multiple > > > source files (one per manufacturer, plus one for the SFDP parsing logic). > > > > > > Signed-off-by: Boris Brezillon > > > Signed-off-by: Tudor Ambarus > > > Reviewed-by: Vignesh Raghavendra > > > > I have no idea why, but with this patch in the upstream kernel I can no longer > > boot aspeed systems from flash with qemu. > > > > Ah yes, it does help to actually build the moved files. The following diff makes > it work again. > > diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile > index 7ddb742de1fe..653923896205 100644 > --- a/drivers/mtd/spi-nor/Makefile > +++ b/drivers/mtd/spi-nor/Makefile > @@ -18,3 +18,5 @@ spi-nor-objs += winbond.o > spi-nor-objs += xilinx.o > spi-nor-objs += xmc.o > obj-$(CONFIG_MTD_SPI_NOR) += spi-nor.o > + > +obj-$(CONFIG_MTD_SPI_NOR) += controllers/ Looks like this line has been lost during a rebase :-/ (it was present in the RFC [1]). [1]https://patchwork.ozlabs.org/patch/1009273/ ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/