From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jason Yan <yanaijie@huawei.com>
Cc: richard@nod.at, tglx@linutronix.de,
linux-mtd@lists.infradead.org, vigneshr@ti.com,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] mtd: physmap_of_gemini: remove defined but not used symbol 'syscon_match'
Date: Mon, 27 Apr 2020 15:53:13 +0200 [thread overview]
Message-ID: <20200427155313.43847da8@xps13> (raw)
In-Reply-To: <20200403081544.37061-1-yanaijie@huawei.com>
Hi Jason,
+ Linus W.
Jason Yan <yanaijie@huawei.com> wrote on Fri, 3 Apr 2020 16:15:44 +0800:
> It's not used by anyone now, remove it. Fix the following gcc warning:
>
> drivers/mtd/maps/physmap-gemini.c:49:34: warning: ‘syscon_match’ defined
> but not used [-Wunused-const-variable=]
> static const struct of_device_id syscon_match[] = {
> ^~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
I am not sure this is the right solution. This compatible has been
added in this driver by Linus in 9d3b5086f6d4 ("mtd: physmap_of_gemini:
Handle pin control"). I believe he had a good reason to do so but you
are right that it is not used. Linus, any input?
> drivers/mtd/maps/physmap-gemini.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mtd/maps/physmap-gemini.c b/drivers/mtd/maps/physmap-gemini.c
> index a289c8b5cabf..d4a46e159d38 100644
> --- a/drivers/mtd/maps/physmap-gemini.c
> +++ b/drivers/mtd/maps/physmap-gemini.c
> @@ -46,11 +46,6 @@
>
> #define FLASH_PARALLEL_HIGH_PIN_CNT (1 << 20) /* else low pin cnt */
>
> -static const struct of_device_id syscon_match[] = {
> - { .compatible = "cortina,gemini-syscon" },
> - { },
> -};
> -
> struct gemini_flash {
> struct device *dev;
> struct pinctrl *p;
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-04-27 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:15 [PATCH] mtd: physmap_of_gemini: remove defined but not used symbol 'syscon_match' Jason Yan
2020-04-27 13:53 ` Miquel Raynal [this message]
2020-04-28 14:16 ` Linus Walleij
2020-04-28 14:20 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427155313.43847da8@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).