From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
<linux-mtd@lists.infradead.org>
Cc: Boris Brezillon <boris.brezillon@collabora.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH v3 2/9] mtd: rawnand: timings: Fix default tR_max and tCCS_min timings
Date: Tue, 28 Apr 2020 11:42:55 +0200 [thread overview]
Message-ID: <20200428094302.14624-3-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20200428094302.14624-1-miquel.raynal@bootlin.com>
tR and tCCS are currently wrongly expressed in femtoseconds, while we
expect these values to be expressed in picoseconds. Set right
hardcoded values.
Fixes: 6a943386ee36 mtd: rawnand: add default values for dynamic timings
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
---
drivers/mtd/nand/raw/nand_timings.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c
index 0061cbaf931d..36d21be3dfe5 100644
--- a/drivers/mtd/nand/raw/nand_timings.c
+++ b/drivers/mtd/nand/raw/nand_timings.c
@@ -320,10 +320,9 @@ int onfi_fill_data_interface(struct nand_chip *chip,
/* microseconds -> picoseconds */
timings->tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX;
timings->tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX;
- timings->tR_max = 1000000ULL * 200000000ULL;
- /* nanoseconds -> picoseconds */
- timings->tCCS_min = 1000UL * 500000;
+ timings->tR_max = 200000000;
+ timings->tCCS_min = 500000;
}
return 0;
--
2.20.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-04-28 9:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 9:42 [PATCH v3 0/9] Misc timing changes Miquel Raynal
2020-04-28 9:42 ` [PATCH v3 1/9] mtd: rawnand: timings: Add mode information to the timings structure Miquel Raynal
2020-05-10 20:05 ` Miquel Raynal
2020-04-28 9:42 ` Miquel Raynal [this message]
2020-05-10 20:05 ` [PATCH v3 2/9] mtd: rawnand: timings: Fix default tR_max and tCCS_min timings Miquel Raynal
2020-04-28 9:42 ` [PATCH v3 3/9] mtd: rawnand: onfi: Fix redundancy detection check Miquel Raynal
2020-05-10 20:05 ` Miquel Raynal
2020-04-28 9:42 ` [PATCH v3 4/9] mtd: rawnand: onfi: Use intermediate variables to improve readability Miquel Raynal
2020-05-10 20:05 ` Miquel Raynal
2020-04-28 9:42 ` [PATCH v3 5/9] mtd: rawnand: onfi: Define the number of parameter pages Miquel Raynal
2020-05-10 20:05 ` Miquel Raynal
2020-04-28 9:42 ` [PATCH v3 6/9] mtd: rawnand: onfi: Avoid doing a copy of the parameter page Miquel Raynal
2020-05-10 20:05 ` Miquel Raynal
2020-04-28 9:43 ` [PATCH v3 7/9] mtd: rawnand: onfi: Drop a useless parameter page read Miquel Raynal
2020-05-10 20:05 ` Miquel Raynal
2020-04-28 9:43 ` [PATCH v3 8/9] mtd: rawnand: jedec: Define the number of parameter pages Miquel Raynal
2020-05-10 20:05 ` Miquel Raynal
2020-04-28 9:43 ` [PATCH v3 9/9] mtd: rawnand: jedec: Use intermediate variables to improve readability Miquel Raynal
2020-05-10 20:04 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428094302.14624-3-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).