From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Kamal Dasu <kamal.dasu@broadcom.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: set mtd partition panic write flag
Date: Sat, 2 May 2020 20:08:06 +0200 [thread overview]
Message-ID: <20200502200806.1d6b1cba@xps13> (raw)
In-Reply-To: <20200109182807.04c8866a@xps13>
Hi Kamal,
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Thu, 9 Jan 2020
18:28:07 +0100:
> Hi Kamal,
>
> Kamal Dasu <kamal.dasu@broadcom.com> wrote on Thu, 9 Jan 2020 10:25:59
> -0500:
>
> > Miquel,
> >
> > Yes the issue is still open. I was trying to understand the suggestion
> > and did not get a reply on the question I had
> >
> > Richard wrote :
> > "So the right fix would be setting the parent's oops_panic_write in
> > mtd_panic_write().
> > Then we don't have to touch mtdpart.c"
> >
> > How do I get access to the parts parent in the core ?. Maybe I am
> > missing something.
>
> I think the solution is to set the oops_panic_write of the root parent, instead of updating the flag of the mtd device itself (which is maybe a partition).
>
> Would this help?
>
> https://www.spinics.net/lists/linux-mtd/msg10454.html
I'm pinging you here as well, as I think you raise a real issue, and we
agreed on a solution, which can now be easily setup with the above
change which has been applied and support for functions like:
static inline struct mtd_info *mtd_get_master(struct mtd_info *mtd)
static inline u64 mtd_get_master_ofs(struct mtd_info *mtd, u64 ofs)
static inline bool mtd_is_partition(const struct mtd_info *mtd)
static inline bool mtd_has_partitions(const struct mtd_info *mtd)
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-02 18:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 19:32 [PATCH] mtd: set mtd partition panic write flag Kamal Dasu
2019-11-05 19:03 ` Miquel Raynal
2019-11-05 23:03 ` Richard Weinberger
2019-11-11 20:35 ` Kamal Dasu
2020-01-09 15:03 ` Miquel Raynal
2020-01-09 15:25 ` Kamal Dasu
2020-01-09 17:28 ` Miquel Raynal
2020-05-02 18:08 ` Miquel Raynal [this message]
2020-05-04 15:20 ` Kamal Dasu
2020-05-04 17:29 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200502200806.1d6b1cba@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kamal.dasu@broadcom.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).