From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 493FCC47247 for ; Tue, 5 May 2020 10:14:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E81520675 for ; Tue, 5 May 2020 10:14:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aFi4LuQC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E81520675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=pAuZ/bGmYFiYWcY8rR92m9ZkTJupMv9q/WZm8QKbOJQ=; b=aFi4LuQCU6dCoh 7/UCcdhBrt3/ptR/X3oRDgZBlBlJaLgVduRm+05gADHESFWFRX+MiEhV0oYcYlsbekPN+r3CpkYrF m/ugvXsSAWsNQVE8I+JxPCuv8+lH7D/6uypSFxDRyFBs1YSXWpTo1K/xBdqh1+6lTcZv4LcEfnv52 L8Y261nppfTzbHsYZUx+Pvz8p7xokgpr/1bXmeRRKQlykgz/blrgg7IvcwADrZCIsuLu91w/s9d6e Ig/9re0UkozzwHYxWQlBxBeJycizmHFXvBtjM4jMIEOVHE2xDWwwkTPDe7uyGJaSD8x8fvKpyL0Qt rYRr9SPhUdza20e8v+gg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVuaQ-00077F-OF; Tue, 05 May 2020 10:14:02 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVuaN-00075N-9s for linux-mtd@lists.infradead.org; Tue, 05 May 2020 10:14:00 +0000 Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:2c:6930:d3ea:1c7:41fd:3038]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id F10852A186A; Tue, 5 May 2020 11:13:56 +0100 (BST) From: Boris Brezillon To: Miquel Raynal , linux-mtd@lists.infradead.org, Lubomir Rintel Subject: [PATCH v2 00/19] mtd: rawnand: cafe: Convert to exec_op() (and more) Date: Tue, 5 May 2020 12:13:34 +0200 Message-Id: <20200505101353.1776394-1-boris.brezillon@collabora.com> X-Mailer: git-send-email 2.25.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200505_031359_473518_F2067BD0 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , Boris Brezillon , Vignesh Raghavendra , Tudor Ambarus Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hello, A bit of context to explain the motivation behind those conversions I've been sending for the last couple of weeks. The raw NAND subsystem carries a lot of history which makes any rework not only painful, but also subject to regressions which we only detect when someone dares to update its kernel on one of those ancient HW. While carrying drivers for old HW is not a problem per se, carrying ancient and unmaintained drivers that are not converted to new APIs is a maintenance burden, hence this massive conversion attempt I'm conducting here. So here is a series converting the CAFE NAND controller driver to exec_op(), plus a bunch of minor improvements done along the way. I hope I'll find someone to test those changes, but if there's no one still owning OLPC HW or no interest in keeping it supported in recent kernel versions, we should definitely consider removing the driver instead. No major changes in this v2, apart from fixes for things reported by Lubomir and Miquel. See the changelog on each patch for more details. Regards, Boris Boris Brezillon (19): mtd: rawnand: Propage CS selection to sub operations mtd: rawnand: cafe: Get rid of an inaccurate kernel doc header mtd: rawnand: cafe: Rename cafe_nand_write_page_lowlevel() mtd: rawnand: cafe: Use a correct ECC mode and pass the ECC alg mtd: rawnand: cafe: Include linux/io.h instead of asm/io.h mtd: rawnand: cafe: Demistify register fields mtd: rawnand: cafe: Factor out the controller initialization logic mtd: rawnand: cafe: Get rid of the debug module param mtd: rawnand: cafe: Use devm_kzalloc and devm_request_irq() mtd: rawnand: cafe: Get rid of a useless label mtd: rawnand: cafe: Explicitly inherit from nand_controller mtd: rawnand: cafe: Don't leave ECC enabled in the write path mtd: rawnand: cafe: Don't split things when reading/writing a page mtd: rawnand: cafe: Add exec_op() support mtd: rawnand: cafe: Get rid of the legacy interface implementation mtd: rawnand: cafe: Adjust the cafe_{read,write}_buf() prototypes mtd: rawnand: cafe: s/uint{8,16,32}_t/u{8,16,32}/ mtd: rawnand: cafe: Drop the cafe_{readl,writel}() wrappers mtd: rawnand: cafe: Get rid of the last printk() drivers/mtd/nand/raw/cafe_nand.c | 798 ++++++++++++++++--------------- drivers/mtd/nand/raw/nand_base.c | 3 +- include/linux/mtd/rawnand.h | 2 + 3 files changed, 410 insertions(+), 393 deletions(-) -- 2.25.3 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/