From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB924C28CBC for ; Wed, 6 May 2020 21:36:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C5A42070B for ; Wed, 6 May 2020 21:36:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MB3wv8m1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C5A42070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LpJ4kvxzCu4u/zBn+KQhV3tYV11CVDFX9PeaqOCu60c=; b=MB3wv8m1DPWDap ddxO0ut0EP+lvqY+/WRMBZtioMDCQbf291081oGDqSAVwLRmsvbON6GXGtsQdACK0VD9InYO3hUW3 du+KVLaq5b5wNhDa0gyLzozlWgaPiGPVAko6pBr+x0F0MkW+TxXE4OJ0f2xVvARjt2uzan9YQtO2P AS0G4wKWrScF7dUOqQC3AbOb4i4VVJAv23vioulu/3TQHXNdTfcB8Sf8HPfDfFhtSgzxBikkiacI0 iJMzgJ94IxrU9UF4fpSIBeuslTAsZ0N6C+xTMcaxvXWibfG2pKbJI7lceOZaND71TLtB6ImM/A9Q2 y9E2oA/2fgcIaXP6XBLA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWRhy-0003mh-Rs; Wed, 06 May 2020 21:36:02 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWRht-0003m7-Ia for linux-mtd@lists.infradead.org; Wed, 06 May 2020 21:36:01 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:b93f:9fae:b276:a89a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 16AB82A0790; Wed, 6 May 2020 22:35:56 +0100 (BST) Date: Wed, 6 May 2020 23:35:52 +0200 From: Boris Brezillon To: Lubomir Rintel Subject: Re: [PATCH v2 00/19] mtd: rawnand: cafe: Convert to exec_op() (and more) Message-ID: <20200506233552.0ef6a865@collabora.com> In-Reply-To: <20200506203635.GA207924@furthur.local> References: <20200505101353.1776394-1-boris.brezillon@collabora.com> <20200505144639.GB1997@furthur.local> <20200505220152.GA157445@furthur.local> <20200506083209.57c85ad9@collabora.com> <20200506155359.GA183666@furthur.local> <20200506181153.4643fbe1@collabora.com> <20200506203635.GA207924@furthur.local> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200506_143558_509455_5247507B X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , Tudor Ambarus , linux-mtd@lists.infradead.org, Vignesh Raghavendra , Miquel Raynal Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, 6 May 2020 22:36:35 +0200 Lubomir Rintel wrote: > > We really should mask IRQs (AKA disable IRQs in my naming convention > > :-)) here, unless we want to switch to interrupt-based waits (which > > would be a good thing when we have DMA or WAIT_RDY involved). Having an > > interrupt handler in the current implementation doesn't make any sense > > (that's assuming the IRQ_STATUS bits are updated even if the interrupts > > are disabled, which am not sure is a valid assumption in this case). > > I have no idea why the interrupt handler is there. Perhaps some > interrupts can't be masked and need an ack or something. Can you try to set NAND_IRQ_MASK to 0x0 and see if that still works. Can you also check the number of NAND interrupts when set to 0x0? It's hard to tell exactly what caused the interrupt handler to be called since this is a shared interrupt. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/