From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Scott Branden <sbranden@broadcom.com>,
Kamal Dasu <kdasu.kdev@gmail.com>, Ray Jui <rjui@broadcom.com>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/3] mtd: rawnand: Add the concept of destructive operation
Date: Mon, 11 May 2020 18:49:24 +0200 [thread overview]
Message-ID: <20200511184924.0bb1358c@xps13> (raw)
In-Reply-To: <20200503100018.308be142@collabora.com>
Hi Boris,
Boris Brezillon <boris.brezillon@collabora.com> wrote on Sun, 3 May
2020 10:00:18 +0200:
> On Sat, 2 May 2020 18:34:30 +0200
> Boris Brezillon <boris.brezillon@collabora.com> wrote:
>
> > Erase and program operations need the WP (Write Protect) pin to be
> > de-asserted to take effect. Let's add the concept of destructive
> > operation and pass the information to exec_op() so controllers know
> > when they should de-assert this pin without having to guess it from
> > the command opcode.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> > ---
> > include/linux/mtd/rawnand.h | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> > index c47cbcb86b71..6014e7389507 100644
> > --- a/include/linux/mtd/rawnand.h
> > +++ b/include/linux/mtd/rawnand.h
> > @@ -854,6 +854,8 @@ struct nand_op_parser {
> > /**
> > * struct nand_operation - NAND operation descriptor
> > * @cs: the CS line to select for this NAND operation
> > + * @deassert_wp: set to true when the operation requires the WP pin to be
> > + * de-asserted (ERASE, PROG, ...)
> > * @instrs: array of instructions to execute
> > * @ninstrs: length of the @instrs array
> > *
> > @@ -861,6 +863,7 @@ struct nand_op_parser {
> > */
> > struct nand_operation {
> > unsigned int cs;
> > + bool deassert_wp;
> > const struct nand_op_instr *instrs;
> > unsigned int ninstrs;
> > };
> > @@ -872,6 +875,14 @@ struct nand_operation {
> > .ninstrs = ARRAY_SIZE(_instrs), \
> > }
> >
> > +#define NAND_DESTRUCTIVE_OPERATION(_cs, _instrs) \
> > + { \
> > + .cs = _cs, \
> > + .deassert_wp = true, \
> > + .instrs = _instrs, \
> > + .ninstrs = ARRAY_SIZE(_instrs), \
> > + }
> > +
> > int nand_op_parser_exec_op(struct nand_chip *chip,
> > const struct nand_op_parser *parser,
> > const struct nand_operation *op, bool check_only);
>
> The following diff should be part of this patch, otherwise none of the
> operations are flagged as destructive. I'll fix that in v2, but I'd still
> like to get feedback before sending a new version.
>
> --->8---
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index fb8addf7637e..4111e7ac0834 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -1308,7 +1308,8 @@ static int nand_exec_prog_page_op(struct nand_chip *chip, unsigned int page,
> NAND_OP_CMD(NAND_CMD_PAGEPROG, PSEC_TO_NSEC(sdr->tWB_max)),
> NAND_OP_WAIT_RDY(PSEC_TO_MSEC(sdr->tPROG_max), 0),
> };
> - struct nand_operation op = NAND_OPERATION(chip->cur_cs, instrs);
> + struct nand_operation op = NAND_DESTRUCTIVE_OPERATION(chip->cur_cs,
> + instrs);
> int naddrs = nand_fill_column_cycles(chip, addrs, offset_in_page);
> int ret;
> u8 status;
> @@ -1695,7 +1696,8 @@ int nand_erase_op(struct nand_chip *chip, unsigned int eraseblock)
> PSEC_TO_MSEC(sdr->tWB_max)),
> NAND_OP_WAIT_RDY(PSEC_TO_MSEC(sdr->tBERS_max), 0),
> };
> - struct nand_operation op = NAND_OPERATION(chip->cur_cs, instrs);
> + struct nand_operation op = NAND_DESTRUCTIVE_OPERATION(chip->cur_cs,
> + instrs);
>
> if (chip->options & NAND_ROW_ADDR_3)
> instrs[1].ctx.addr.naddrs++;
What about nand_prog_page_end_op() or even
nand_write_change_column_op()?
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-11 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 16:34 [PATCH 0/3] mtd: rawnand: brcmnand: Convert to exec_op() Boris Brezillon
2020-05-02 16:34 ` [PATCH 1/3] mtd: rawnand: Add the concept of destructive operation Boris Brezillon
2020-05-03 8:00 ` Boris Brezillon
2020-05-11 16:49 ` Miquel Raynal [this message]
2020-05-02 16:34 ` [PATCH 2/3] mtd: rawnand: bcrmnand: Add exec_op() support Boris Brezillon
2020-05-11 16:57 ` Miquel Raynal
2020-05-02 16:34 ` [PATCH 3/3] mtd: rawnand: brcmnand: Get rid of the legacy interface implementation Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511184924.0bb1358c@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=boris.brezillon@collabora.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=lee@kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=richard@nod.at \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).