From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4523C433DF for ; Tue, 19 May 2020 13:17:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D15E206D4 for ; Tue, 19 May 2020 13:17:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="penK5Lwn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UaeKy72p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D15E206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e2VEdF2PVDc8ZxNub/bBEEa72Ti/lT+95HR8kECJwyQ=; b=penK5LwnhMZF41 qeNv3+qJTwXmuErMT4R3FZADdiPvFVQiEC0pwRzt2TkAhoZex5C/gPH7sM0z8bg9tPNoy0mrBYKxB zerTEFKn8ypM1D0dfnV6nmPqUG1zCxdwMQqbSSQlBthbpQVSqEwnoUgTFcuWuSoPGQZgQsjx/plcy 5s9MKVz4Uj0TM5o8xJyYZKystgz8d0UmcpgKF9+UlJ3aYrdFNJYhpG7Kv3K64eeNqdNlSwn20koV6 qGMXBj/BGyFh2IMzMrgFm6CxYmxLyEsZACbGBIB5vB8dvrGtTYk1NjbCmQieR6vVOftohaMp49LMv zsaZOhxFTUHEMUliII8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb27c-0006up-Iy; Tue, 19 May 2020 13:17:28 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb1sS-0002iJ-TX for linux-mtd@bombadil.infradead.org; Tue, 19 May 2020 13:01:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=n3d4ELJ4iBUusJ1vcD/d/OY+vvs1HUcyATbJH7rsdaM=; b=UaeKy72p0A5O86NwnmMbafhvlq vxm8TdnR1jlXugYCKGIMmKt38C5T6OfVxfmRYhRwlyxdP4COi7ffelLDPCKIqgCDT1ZuyUTq2zGu/ AO0QDrqU0v/NT1cw/8gGL9xVtlSGGLAibibs8Ir/6LKAu5pFlE2kyo5CVx7XhxXYa4oO2bdv7TXlO krpjimVPOwmA4dQhyrFtjP5ZGHqdd1kIjKxuSeQxOqm9A+FUi8Q8NQxlTC7MsqykRyk5HdUAaOY7W OXRinl92dCZQorPRfE8dWKG/+zSUbsXnPvrJl4GgZJ/NcUB93jLZEf8d21oNIWSTASzl3xL88ZSj8 FJXu+vyg==; Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb1sO-0002KL-5O for linux-mtd@lists.infradead.org; Tue, 19 May 2020 13:01:47 +0000 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id A1B15FF806; Tue, 19 May 2020 13:01:01 +0000 (UTC) From: Miquel Raynal To: Subject: [PATCH v2 42/62] mtd: rawnand: plat_nand: Fix the probe error path Date: Tue, 19 May 2020 15:00:15 +0200 Message-Id: <20200519130035.1883-43-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130035.1883-1-miquel.raynal@bootlin.com> References: <20200519130035.1883-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200519_140144_524220_79369F4D X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Miquel Raynal Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. There is no real Fixes tag applying here as the use of nand_release() in this driver predates by far the introduction of nand_cleanup() in commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") which makes this change possible, hence pointing it as the commit to fix for backporting purposes, even if this commit is not introducing any bug. Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org --- drivers/mtd/nand/raw/plat_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/plat_nand.c b/drivers/mtd/nand/raw/plat_nand.c index dc0f3074ddbf..3a495b233443 100644 --- a/drivers/mtd/nand/raw/plat_nand.c +++ b/drivers/mtd/nand/raw/plat_nand.c @@ -92,7 +92,7 @@ static int plat_nand_probe(struct platform_device *pdev) if (!err) return err; - nand_release(&data->chip); + nand_cleanup(&data->chip); out: if (pdata->ctrl.remove) pdata->ctrl.remove(pdev); -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/