linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Rickard X Andersson <Rickard.Andersson@axis.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Boris Brezillon <bbrezillon@kernel.org>
Subject: Re: [PATCH 2/2] mtd: rawnand: Add timings for Kioxia TH58NVG2S3HBAI4
Date: Wed, 20 May 2020 15:43:43 +0200	[thread overview]
Message-ID: <20200520154343.2ce58cc6@xps13> (raw)
In-Reply-To: <1589981533129.2663@axis.com>

Hi Rickard,

Rickard X Andersson <Rickard.Andersson@axis.com> wrote on Wed, 20 May
2020 13:32:14 +0000:

> Hi Miquel,
> 
> > I just a branch with a new helper to fill this field, it is called
> > onfi_find_equivalent_sdr_mode().
> >
> > It is only compile tested so please verify it works.  
> 
> I have created a new patchset that I will send shortly. This patchset does however not use onfi_find_equivalent_sdr_mode(..), that could be a future improvment. My patchset falls back to mode 0 if the specialized timings does not work for the controller. 

Thanks for updating!

Actually I wrote it because of a previous discussion with Boris who
told me that this mode field would be badly understood and he actually
got it right as in your previous submission this field was set to 0
while, IIRC, you told me it was close to mode 3. This is important to
controllers that cannot tweak the parameters but just pick an ONFI
mode. So the timings they choose must fit the slowest mins and fastest
maxs of your new set of timings. Hence the use of the helper which
seems needed. It is actually pretty straightforward so I don't
understand your choice of not making use of it?

As this is the primary contribution of this type, I would like to get
it right so that other contributors can refer to it :)

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-05-20 13:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 13:32 SV: [PATCH 2/2] mtd: rawnand: Add timings for Kioxia TH58NVG2S3HBAI4 Rickard X Andersson
2020-05-20 13:43 ` Miquel Raynal [this message]
2020-05-20 14:16   ` Rickard X Andersson
2020-05-20 14:29     ` Miquel Raynal
2020-05-20 14:42       ` SV: " Rickard X Andersson
2020-05-20 14:50         ` Boris Brezillon
2020-05-20 15:12           ` Miquel Raynal
2020-05-20 15:26             ` Boris Brezillon
2020-05-20 20:43               ` Miquel Raynal
2020-05-20 20:57                 ` Boris Brezillon
     [not found] <richard@nod.at;>
2020-05-14  9:13 ` [PATCH 1/2] mtd: rawnand: Use the ->init_data_interface() hook Rickard Andersson
2020-05-14  9:13   ` [PATCH 2/2] mtd: rawnand: Add timings for Kioxia TH58NVG2S3HBAI4 Rickard Andersson
2020-05-19 12:08     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200520154343.2ce58cc6@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Rickard.Andersson@axis.com \
    --cc=bbrezillon@kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).