Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] mtd: rawnand: gpmi: Fix runtime PM imbalance in gpmi_nand_probe
@ 2020-05-22 10:17 Dinghao Liu
  2020-05-24 19:03 ` Miquel Raynal
  0 siblings, 1 reply; 2+ messages in thread
From: Dinghao Liu @ 2020-05-22 10:17 UTC (permalink / raw)
  To: dinghao.liu, kjlu
  Cc: Vignesh Raghavendra, Richard Weinberger, linux-kernel, linux-mtd,
	Miquel Raynal, Han Xu

There is no reason that the failure of __gpmi_enable_clk()
could lead to PM usage counter decrement.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
 drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
index 53b00c841aec..3c5237e6f050 100644
--- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
@@ -2658,7 +2658,7 @@ static int gpmi_nand_probe(struct platform_device *pdev)
 
 	ret = __gpmi_enable_clk(this, true);
 	if (ret)
-		goto exit_nfc_init;
+		goto exit_acquire_resources;
 
 	pm_runtime_set_autosuspend_delay(&pdev->dev, 500);
 	pm_runtime_use_autosuspend(&pdev->dev);
-- 
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd: rawnand: gpmi: Fix runtime PM imbalance in gpmi_nand_probe
  2020-05-22 10:17 [PATCH] mtd: rawnand: gpmi: Fix runtime PM imbalance in gpmi_nand_probe Dinghao Liu
@ 2020-05-24 19:03 ` Miquel Raynal
  0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2020-05-24 19:03 UTC (permalink / raw)
  To: Dinghao Liu, kjlu
  Cc: Vignesh Raghavendra, Richard Weinberger, linux-kernel, linux-mtd,
	Miquel Raynal, Han Xu

On Fri, 2020-05-22 at 10:17:13 UTC, Dinghao Liu wrote:
> There is no reason that the failure of __gpmi_enable_clk()
> could lead to PM usage counter decrement.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 10:17 [PATCH] mtd: rawnand: gpmi: Fix runtime PM imbalance in gpmi_nand_probe Dinghao Liu
2020-05-24 19:03 ` Miquel Raynal

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git