From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4223C433E1 for ; Sun, 24 May 2020 19:18:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83B12207D8 for ; Sun, 24 May 2020 19:18:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gPDOC/o+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83B12207D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TzdAY1zBXdWrQVt+xWVSPJNmAd5ABbzRRB3BRyFSrrA=; b=gPDOC/o+r57Jqc CBYbimeCTj+sQ05aMPrayul8HwrwpVEl6MQed0BZMfUg20iKRLHpY+4HmvzAdYL4d/dtqC8c+IOgr +GHSRVtEY/xoeBFP2HwN2iPYw4yD1w/FKDcBXB4yawB6ftu8LlL1NUOXdyzzeA5wRs4WlE2DMZHdx knCrwfVzbVe7yz7TR3Da1N6xfKn2FR+IpxhxMo5+TeR4GzWEtNVW06kCRReIzI8h6E+snYXFDgp40 H1D2I3BVzQC813qEjleEcZQQnMgvobr2uV0pZfXLZbTJ1OD94juILjNnVNQhEj3MPw3edRhaZeCsV Opk8pKujTPMQfGJ8vgqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcw8w-0003S5-U1; Sun, 24 May 2020 19:18:42 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcvym-00065n-41 for linux-mtd@lists.infradead.org; Sun, 24 May 2020 19:08:15 +0000 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id EB39920006; Sun, 24 May 2020 19:08:09 +0000 (UTC) From: Miquel Raynal To: Miquel Raynal , linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 12/62] mtd: rawnand: diskonchip: Fix the probe error path Date: Sun, 24 May 2020 21:08:08 +0200 Message-Id: <20200524190809.3669-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130035.1883-13-miquel.raynal@bootlin.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: 745944a1d8a2bd53876f9464d2c9cd4e12f86312 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200524_120812_314599_35C919B0 X-CRM114-Status: GOOD ( 10.59 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 2020-05-19 at 12:59:45 UTC, Miquel Raynal wrote: > Not sure nand_cleanup() is the right function to call here but in any > case it is not nand_release(). Indeed, even a comment says that > calling nand_release() is a bit of a hack as there is no MTD device to > unregister. So switch to nand_cleanup() for now and drop this > comment. > > There is no Fixes tag applying here as the use of nand_release() > in this driver predates by far the introduction of nand_cleanup() in > commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") > which makes this change possible. However, pointing this commit as the > culprit for backporting purposes makes sense even if it did not intruce > any bug. > > Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") > Signed-off-by: Miquel Raynal > Cc: stable@vger.kernel.org Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next. Miquel ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/