From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA514C433DF for ; Mon, 25 May 2020 17:48:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C079C20776 for ; Mon, 25 May 2020 17:48:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qe0rJjAB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C079C20776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YIg8+5XKcpx7HVI5jn8wt4oFSqVCO5vkbiYoO81lNyk=; b=qe0rJjAB9bsWGb MdRL91JBFp1ss52gWIURCN8R4tpr/gs160PiEVW8YA6LI6g5ZOjjMCYRBMjgX0TJ9+slXLuQ/PHI5 +eGnsgjRbkaVs7G6HIi6sFQwYG+qBKu1D0iuptBOBhmWyesJHhKAl5ekIu9TKB6VvwvNLctiX/F2P iCO5qvblPrf46GH5MJWQTyAbwAN2QyDOssUAGrqKHKxrtp/q1ib4D2tQfEvr4gjjkzIcV7xSRfOCw ftVrOn6KTiZjCE2Mov+k5ybMe+6XAZtoLb0tYKmN79wz2ODSUtKPHqux4f6hPc3ufRIm4RkhFCQrU lLsJ2wplQreUPDtPPE3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdHCx-0001bq-VP; Mon, 25 May 2020 17:48:16 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdH7x-0003Lo-Ew for linux-mtd@lists.infradead.org; Mon, 25 May 2020 17:43:07 +0000 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 339CA24000E; Mon, 25 May 2020 17:43:03 +0000 (UTC) From: Miquel Raynal To: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Subject: [PATCH v4 18/19] mtd: rawnand: Add the ->choose_data_interface() hook Date: Mon, 25 May 2020 19:42:38 +0200 Message-Id: <20200525174239.11349-19-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200525174239.11349-1-miquel.raynal@bootlin.com> References: <20200525174239.11349-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200525_104305_755543_5DCEE89F X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rickard Andersson , Boris Brezillon , Miquel Raynal Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org This hook can be overloaded by NAND manufacturer drivers to propose alternative timings when not following the main standards. Vendors implementing this hook should: 1- choose the best timings and fill the data interface, 2- verify that the controller supports them. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/raw/internals.h | 5 +++++ drivers/mtd/nand/raw/nand_base.c | 8 ++++++++ include/linux/mtd/rawnand.h | 2 ++ 3 files changed, 15 insertions(+) diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h index 9af6979257e2..61edbab35068 100644 --- a/drivers/mtd/nand/raw/internals.h +++ b/drivers/mtd/nand/raw/internals.h @@ -146,6 +146,11 @@ static inline bool nand_controller_has_setup_data_iface(struct nand_chip *chip) return true; } +static inline bool nand_can_choose_data_interface(struct nand_chip *chip) +{ + return chip->ops.choose_data_interface; +} + /* BBT functions */ int nand_markbad_bbt(struct nand_chip *chip, loff_t offs); int nand_isreserved_bbt(struct nand_chip *chip, loff_t offs); diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index d9fe7795f183..e9df339849d3 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -1060,6 +1060,14 @@ static int nand_choose_data_interface(struct nand_chip *chip) if (!nand_controller_has_setup_data_iface(chip)) return 0; + /* + * Let the NAND vendor hook identify the best timings. + * ->choose_data_interface() is expected to update the entire chip's + * nand_data_interface structure. + */ + if (nand_can_choose_data_interface(chip)) + return chip->ops.choose_data_interface(chip); + /* * First try to identify the best timings from ONFI parameters and * if the NAND does not support ONFI, fallback to the default ONFI diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h index a4b68e7b246a..5b8b94521a18 100644 --- a/include/linux/mtd/rawnand.h +++ b/include/linux/mtd/rawnand.h @@ -1034,6 +1034,7 @@ struct nand_legacy { * @lock_area: Lock operation * @unlock_area: Unlock operation * @setup_read_retry: Set the read-retry mode (mostly needed for MLC NANDs) + * @choose_data_interface: Choose the best data interface */ struct nand_chip_ops { int (*suspend)(struct nand_chip *chip); @@ -1041,6 +1042,7 @@ struct nand_chip_ops { int (*lock_area)(struct nand_chip *chip, loff_t ofs, uint64_t len); int (*unlock_area)(struct nand_chip *chip, loff_t ofs, uint64_t len); int (*setup_read_retry)(struct nand_chip *chip, int retry_mode); + int (*choose_data_interface)(struct nand_chip *chip); }; /** -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/