From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
<linux-mtd@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>
Cc: Julien Su <juliensu@mxic.com.tw>,
Weijie Gao <weijie.gao@mediatek.com>,
Paul Cercueil <paul@crapouillou.net>,
Boris Brezillon <boris.brezillon@collabora.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Mason Yang <masonccyang@mxic.com.tw>,
Chuanhong Guo <gch981213@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 14/20] mtd: nand: Add more parameters to the nand_ecc_props structure
Date: Fri, 29 May 2020 02:25:11 +0200 [thread overview]
Message-ID: <20200529002517.3546-15-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20200529002517.3546-1-miquel.raynal@bootlin.com>
Prepare the migration to the generic ECC framework by adding more
fields to the nand_ecc_props structure which will be used widely to
describe different kind of ECC properties.
Doing this imposes to move the engine type, ECC placement and
algorithm enumerations in a shared place: nand.h.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
include/linux/mtd/nand.h | 50 +++++++++++++++++++++++++++++++++++++
include/linux/mtd/rawnand.h | 44 --------------------------------
2 files changed, 50 insertions(+), 44 deletions(-)
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 6add464fd18b..9aacdf9dc779 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -127,12 +127,62 @@ struct nand_page_io_req {
int mode;
};
+/**
+ * enum nand_ecc_engine_type - NAND ECC engine type
+ * @NAND_ECC_ENGINE_TYPE_INVALID: Invalid value
+ * @NAND_ECC_ENGINE_TYPE_NONE: No ECC correction
+ * @NAND_ECC_ENGINE_TYPE_SOFT: Software ECC correction
+ * @NAND_ECC_ENGINE_TYPE_ON_HOST: On host hardware ECC correction
+ * @NAND_ECC_ENGINE_TYPE_ON_DIE: On chip hardware ECC correction
+ */
+enum nand_ecc_engine_type {
+ NAND_ECC_ENGINE_TYPE_INVALID,
+ NAND_ECC_ENGINE_TYPE_NONE,
+ NAND_ECC_ENGINE_TYPE_SOFT,
+ NAND_ECC_ENGINE_TYPE_ON_HOST,
+ NAND_ECC_ENGINE_TYPE_ON_DIE,
+};
+
+/**
+ * enum nand_ecc_placement - NAND ECC bytes placement
+ * @NAND_ECC_PLACEMENT_UNKNOWN: The actual position of the ECC bytes is unknown
+ * @NAND_ECC_PLACEMENT_OOB: The ECC bytes are located in the OOB area
+ * @NAND_ECC_PLACEMENT_INTERLEAVED: Syndrome layout, there are ECC bytes
+ * interleaved with regular data in the main
+ * area
+ */
+enum nand_ecc_placement {
+ NAND_ECC_PLACEMENT_UNKNOWN,
+ NAND_ECC_PLACEMENT_OOB,
+ NAND_ECC_PLACEMENT_INTERLEAVED,
+};
+
+/**
+ * enum nand_ecc_algo - NAND ECC algorithm
+ * @NAND_ECC_ALGO_UNKNOWN: Unknown algorithm
+ * @NAND_ECC_ALGO_HAMMING: Hamming algorithm
+ * @NAND_ECC_ALGO_BCH: Bose-Chaudhuri-Hocquenghem algorithm
+ * @NAND_ECC_ALGO_RS: Reed-Solomon algorithm
+ */
+enum nand_ecc_algo {
+ NAND_ECC_ALGO_UNKNOWN,
+ NAND_ECC_ALGO_HAMMING,
+ NAND_ECC_ALGO_BCH,
+ NAND_ECC_ALGO_RS,
+};
+
/**
* struct nand_ecc_props - NAND ECC properties
+ * @engine_type: ECC engine type
+ * @placement: OOB placement (if relevant)
+ * @algo: ECC algorithm (if relevant)
* @strength: ECC strength
* @step_size: Number of bytes per step
*/
struct nand_ecc_props {
+ enum nand_ecc_engine_type engine_type;
+ enum nand_ecc_placement placement;
+ enum nand_ecc_algo algo;
unsigned int strength;
unsigned int step_size;
};
diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index c3411a08ce61..8f7f1cce3b4b 100644
--- a/include/linux/mtd/rawnand.h
+++ b/include/linux/mtd/rawnand.h
@@ -92,50 +92,6 @@ enum nand_ecc_mode {
NAND_ECC_ON_DIE,
};
-/**
- * enum nand_ecc_engine_type - NAND ECC engine type
- * @NAND_ECC_ENGINE_TYPE_INVALID: Invalid value
- * @NAND_ECC_ENGINE_TYPE_NONE: No ECC correction
- * @NAND_ECC_ENGINE_TYPE_SOFT: Software ECC correction
- * @NAND_ECC_ENGINE_TYPE_ON_HOST: On host hardware ECC correction
- * @NAND_ECC_ENGINE_TYPE_ON_DIE: On chip hardware ECC correction
- */
-enum nand_ecc_engine_type {
- NAND_ECC_ENGINE_TYPE_INVALID,
- NAND_ECC_ENGINE_TYPE_NONE,
- NAND_ECC_ENGINE_TYPE_SOFT,
- NAND_ECC_ENGINE_TYPE_ON_HOST,
- NAND_ECC_ENGINE_TYPE_ON_DIE,
-};
-
-/**
- * enum nand_ecc_placement - NAND ECC bytes placement
- * @NAND_ECC_PLACEMENT_UNKNOWN: The actual position of the ECC bytes is unknown
- * @NAND_ECC_PLACEMENT_OOB: The ECC bytes are located in the OOB area
- * @NAND_ECC_PLACEMENT_INTERLEAVED: Syndrome layout, there are ECC bytes
- * interleaved with regular data in the main
- * area
- */
-enum nand_ecc_placement {
- NAND_ECC_PLACEMENT_UNKNOWN,
- NAND_ECC_PLACEMENT_OOB,
- NAND_ECC_PLACEMENT_INTERLEAVED,
-};
-
-/**
- * enum nand_ecc_algo - NAND ECC algorithm
- * @NAND_ECC_ALGO_UNKNOWN: Unknown algorithm
- * @NAND_ECC_ALGO_HAMMING: Hamming algorithm
- * @NAND_ECC_ALGO_BCH: Bose-Chaudhuri-Hocquenghem algorithm
- * @NAND_ECC_ALGO_RS: Reed-Solomon algorithm
- */
-enum nand_ecc_algo {
- NAND_ECC_ALGO_UNKNOWN,
- NAND_ECC_ALGO_HAMMING,
- NAND_ECC_ALGO_BCH,
- NAND_ECC_ALGO_RS,
-};
-
/*
* Constants for Hardware ECC
*/
--
2.20.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-29 0:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 0:24 [PATCH v7 00/20] Introduce the generic ECC engine abstraction Miquel Raynal
2020-05-29 0:24 ` [PATCH v7 01/20] dt-bindings: mtd: Document nand-ecc-placement Miquel Raynal
2020-05-29 22:21 ` Rob Herring
2020-05-29 0:24 ` [PATCH v7 02/20] mtd: rawnand: Create a new enumeration to describe ECC bytes placement Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 03/20] mtd: rawnand: Separate the ECC engine type and the ECC byte placement Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 04/20] mtd: rawnand: Create a helper to retrieve the ECC placement Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 05/20] mtd: rawnand: Add a kernel doc to the ECC algorithm enumeration Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 06/20] mtd: rawnand: Rename the ECC algorithm enumeration items Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 07/20] mtd: rawnand: Create a new enumeration to describe properly ECC types Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 08/20] mtd: rawnand: Use the new ECC engine type enumeration Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 09/20] mtd: nand: Move nand_device forward declaration to the top Miquel Raynal
2020-06-15 9:08 ` Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 10/20] mtd: nand: Add an extra level in the Kconfig hierarchy Miquel Raynal
2020-06-15 9:07 ` Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 11/20] mtd: nand: Drop useless 'depends on' in Kconfig Miquel Raynal
2020-06-15 9:07 ` Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 12/20] mtd: nand: Add a NAND page I/O request type Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 13/20] mtd: nand: Rename a core structure Miquel Raynal
2020-06-15 9:07 ` Miquel Raynal
2020-05-29 0:25 ` Miquel Raynal [this message]
2020-05-29 0:25 ` [PATCH v7 15/20] mtd: nand: Introduce the ECC engine abstraction Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 16/20] mtd: nand: Convert generic NAND bits to use the ECC framework Miquel Raynal
2020-05-29 8:32 ` Boris Brezillon
2020-05-29 9:25 ` Miquel Raynal
2020-05-29 8:35 ` Boris Brezillon
2020-05-29 0:25 ` [PATCH v7 17/20] mtd: rawnand: Hide the generic OOB layout objects behind helpers Miquel Raynal
2020-05-29 8:45 ` Boris Brezillon
2020-05-29 8:46 ` Boris Brezillon
2020-05-29 9:17 ` Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 18/20] mtd: rawnand: Write a compatibility layer Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 19/20] mtd: rawnand: Move generic OOB layouts to the ECC framework Miquel Raynal
2020-05-29 0:25 ` [PATCH v7 20/20] mtd: rawnand: Move the user input parsing bits " Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529002517.3546-15-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=gch981213@gmail.com \
--cc=juliensu@mxic.com.tw \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).