From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F609C433E0 for ; Wed, 3 Jun 2020 13:58:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2448F206A2 for ; Wed, 3 Jun 2020 13:58:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rtCCCWuK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2448F206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g1QvsNgLbH37Vb1+5H/kvVXJhZTjS3PCNyQaCa3qiZs=; b=rtCCCWuKFLCpri ChNllwn/SmCiJF7E//Ewypzfaoq+TXiC5Pxq21b33wiLuhFxF7iAzhLgfTuFjp4mvEmdwPdrYCZI8 Gjx85bKRgWKOJ2jzmGpd+qDXFlfxYi/fX02+Jtpjt2RpYlL176h5j3mgYZdJL57FqVmy8A0A+QTS6 GMNli2Ah7OX4JaWvguhLneVz2KtbWuumo2reO0KAKz1xHdVf6jT9gj8vxM1iWtIn4rnmdNwLm3/v7 +or0VMqXLA+zPknAXybKAV3iLnX0VrzG0GzhcoxrOtkXh9M9j9qLtEpkun8ypADTCtz710TwUL8TZ gscJ1WNoVs3EQ+KmnK5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgTuM-0003W7-9W; Wed, 03 Jun 2020 13:58:18 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgTuI-0003VG-H7 for linux-mtd@lists.infradead.org; Wed, 03 Jun 2020 13:58:16 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id DE971FF80B; Wed, 3 Jun 2020 13:58:03 +0000 (UTC) Date: Wed, 3 Jun 2020 15:58:02 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH 05/10] mtd: rawnand: fsl_upm: Use platform_get_resource() + devm_ioremap_resource() Message-ID: <20200603155802.12165328@xps13> In-Reply-To: <20200603134922.1352340-6-boris.brezillon@collabora.com> References: <20200603134922.1352340-1-boris.brezillon@collabora.com> <20200603134922.1352340-6-boris.brezillon@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200603_065814_704485_CC674863 X-CRM114-Status: GOOD ( 13.14 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Michael Ellerman , Anton Vorontsov , Richard Weinberger , linux-mtd@lists.infradead.org, Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Boris Brezillon wrote on Wed, 3 Jun 2020 15:49:17 +0200: > Replace the of_address_to_resource() + devm_ioremap() calls by > platform_get_resource() + devm_ioremap_resource() ones which allows us > to get rid of one error message since devm_ioremap_resource() already > takes care of that. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/raw/fsl_upm.c | 23 +++++++---------------- > 1 file changed, 7 insertions(+), 16 deletions(-) > > diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c > index a3e3a968891d..54851e9ea784 100644 > --- a/drivers/mtd/nand/raw/fsl_upm.c > +++ b/drivers/mtd/nand/raw/fsl_upm.c > @@ -14,7 +14,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -197,7 +196,7 @@ static int fun_chip_init(struct fsl_upm_nand *fun, > static int fun_probe(struct platform_device *ofdev) > { > struct fsl_upm_nand *fun; > - struct resource io_res; > + struct resource *io_res; > const __be32 *prop; > int rnb_gpio; > int ret; > @@ -208,13 +207,12 @@ static int fun_probe(struct platform_device *ofdev) > if (!fun) > return -ENOMEM; > > - ret = of_address_to_resource(ofdev->dev.of_node, 0, &io_res); > - if (ret) { > - dev_err(&ofdev->dev, "can't get IO base\n"); > - return ret; > - } > + io_res = platform_get_resource(ofdev, IORESOURCE_MEM, 0); > + fun->io_base = devm_ioremap_resource(&ofdev->dev, io_res); Why not even using devm_platform_ioremap_resource() resource directly? ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/