From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Anton Vorontsov <anton@enomsg.org>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 08/10] mtd: rawnand: fsl_upm: Implement exec_op()
Date: Wed, 3 Jun 2020 16:08:24 +0200 [thread overview]
Message-ID: <20200603160824.3adae7b8@xps13> (raw)
In-Reply-To: <20200603134922.1352340-9-boris.brezillon@collabora.com>
Boris Brezillon <boris.brezillon@collabora.com> wrote on Wed, 3 Jun
2020 15:49:20 +0200:
> Implement exec_op() so we can get rid of the legacy interface
> implementation.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/mtd/nand/raw/fsl_upm.c | 86 ++++++++++++++++++++++++++++++++++
> 1 file changed, 86 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c
> index 9a63e36825d8..03ca20930274 100644
> --- a/drivers/mtd/nand/raw/fsl_upm.c
> +++ b/drivers/mtd/nand/raw/fsl_upm.c
> @@ -194,6 +194,91 @@ static int fun_chip_init(struct fsl_upm_nand *fun,
> return ret;
> }
>
> +static int func_exec_instr(struct nand_chip *chip,
> + const struct nand_op_instr *instr)
> +{
> + struct fsl_upm_nand *fun = to_fsl_upm_nand(nand_to_mtd(chip));
> + u32 mar, reg_offs = fun->mchip_offsets[fun->mchip_number];
> + unsigned int i;
> + const u8 *out;
> + u8 *in;
> +
> + switch (instr->type) {
> + case NAND_OP_CMD_INSTR:
> + fsl_upm_start_pattern(&fun->upm, fun->upm_cmd_offset);
> + mar = (instr->ctx.cmd.opcode << (32 - fun->upm.width)) |
> + reg_offs;
> + fsl_upm_run_pattern(&fun->upm, fun->io_base + reg_offs, mar);
> + fsl_upm_end_pattern(&fun->upm);
> + return 0;
> +
> + case NAND_OP_ADDR_INSTR:
> + fsl_upm_start_pattern(&fun->upm, fun->upm_addr_offset);
> + for (i = 0; i < instr->ctx.addr.naddrs; i++) {
> + mar = (instr->ctx.addr.addrs[i] << (32 - fun->upm.width)) |
> + reg_offs;
> + fsl_upm_run_pattern(&fun->upm, fun->io_base + reg_offs, mar);
> + }
> + fsl_upm_end_pattern(&fun->upm);
> + return 0;
> +
> + case NAND_OP_DATA_IN_INSTR:
> + in = instr->ctx.data.buf.in;
> + for (i = 0; i < instr->ctx.data.len; i++)
> + in[i] = in_8(fun->io_base + reg_offs);
> + return 0;
> +
> + case NAND_OP_DATA_OUT_INSTR:
> + out = instr->ctx.data.buf.out;
> + for (i = 0; i < instr->ctx.data.len; i++)
> + out_8(fun->io_base + reg_offs, out[i]);
> + return 0;
> +
> + case NAND_OP_WAITRDY_INSTR:
> + if (!fun->rnb_gpio[fun->mchip_number])
> + return nand_soft_waitrdy(chip, instr->ctx.waitrdy.timeout_ms);
> +
> + return nand_gpio_waitrdy(chip, fun->rnb_gpio[fun->mchip_number],
> + instr->ctx.waitrdy.timeout_ms);
> +
> + default:
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
> +
> +static int fun_exec_op(struct nand_chip *chip, const struct nand_operation *op,
> + bool check_only)
> +{
> + struct fsl_upm_nand *fun = to_fsl_upm_nand(nand_to_mtd(chip));
> + unsigned int i;
> + int ret;
> +
> + if (op->cs > NAND_MAX_CHIPS)
> + return -EINVAL;
> +
> + if (check_only)
> + return 0;
> +
> + fun->mchip_number = op->cs;
> +
> + for (i = 0; i < op->ninstrs; i++) {
> + ret = func_exec_instr(chip, &op->instrs[i]);
> + if (ret)
> + return ret;
> +
> + if (op->instrs[i].delay_ns)
> + ndelay(op->instrs[i].delay_ns);
> + }
> +
> + return 0;
> +}
> +
> +static const struct nand_controller_ops fun_ops = {
> + .exec_op = fun_exec_op,
> +};
> +
> static int fun_probe(struct platform_device *ofdev)
> {
> struct fsl_upm_nand *fun;
> @@ -271,6 +356,7 @@ static int fun_probe(struct platform_device *ofdev)
> FSL_UPM_WAIT_WRITE_BYTE;
>
> nand_controller_init(&fun->base);
> + fun->base.ops = &fun_ops;
> fun->dev = &ofdev->dev;
> fun->last_ctrl = NAND_CLE;
>
Looks fine!
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-06-03 14:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 13:49 [PATCH 00/10] mtd: rawnand: fsl_upm: Convert to exec_op() (and more) Boris Brezillon
2020-06-03 13:49 ` [PATCH 01/10] mtd: rawnand: fsl_upm: Remove unused mtd var Boris Brezillon
2020-06-03 13:50 ` Miquel Raynal
2020-06-15 9:02 ` Miquel Raynal
2020-06-03 13:49 ` [PATCH 02/10] mtd: rawnand: fsl_upm: Get rid of the unused fsl_upm_nand.parts field Boris Brezillon
2020-06-03 13:50 ` Miquel Raynal
2020-06-15 9:02 ` Miquel Raynal
2020-06-03 13:49 ` [PATCH 03/10] mtd: rawnand: fsl_upm: Allocate the fsl_upm_nand object using devm_kzalloc() Boris Brezillon
2020-06-03 13:52 ` Miquel Raynal
2020-06-15 9:02 ` Miquel Raynal
2020-06-03 13:49 ` [PATCH 04/10] mtd: rawnand: fsl_upm: Use devm_kasprintf() to allocate the MTD name Boris Brezillon
2020-06-03 13:55 ` Miquel Raynal
2020-06-03 13:59 ` Boris Brezillon
2020-06-15 9:02 ` Miquel Raynal
2020-06-03 13:49 ` [PATCH 05/10] mtd: rawnand: fsl_upm: Use platform_get_resource() + devm_ioremap_resource() Boris Brezillon
2020-06-03 13:58 ` Miquel Raynal
2020-06-03 14:00 ` Boris Brezillon
2020-06-15 9:01 ` Miquel Raynal
2020-06-03 13:49 ` [PATCH 06/10] mtd: rawnand: fsl_upm: Use gpio descriptors Boris Brezillon
2020-06-03 13:59 ` Miquel Raynal
2020-06-15 9:01 ` Miquel Raynal
2020-06-03 13:49 ` [PATCH 07/10] mtd: rawnand: fsl_upm: Inherit from nand_controller Boris Brezillon
2020-06-03 14:01 ` Miquel Raynal
2020-06-15 9:01 ` Miquel Raynal
2020-06-03 13:49 ` [PATCH 08/10] mtd: rawnand: fsl_upm: Implement exec_op() Boris Brezillon
2020-06-03 14:08 ` Miquel Raynal [this message]
2020-06-15 9:01 ` Miquel Raynal
2020-06-03 13:49 ` [PATCH 09/10] mtd: rawnand: fsl_upm: Get rid of the legacy interface implementation Boris Brezillon
2020-06-15 9:01 ` Miquel Raynal
2020-06-03 13:49 ` [PATCH 10/10] dt-bindings: mtd: fsl-upm-nand: Deprecate chip-delay and fsl, upm-wait-flags Boris Brezillon
2020-06-03 13:52 ` [PATCH 10/10] dt-bindings: mtd: fsl-upm-nand: Deprecate chip-delay and fsl,upm-wait-flags Boris Brezillon
2020-07-07 19:04 ` [PATCH 10/10] dt-bindings: mtd: fsl-upm-nand: Deprecate chip-delay and fsl, upm-wait-flags Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603160824.3adae7b8@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=anton@enomsg.org \
--cc=benh@kernel.crashing.org \
--cc=boris.brezillon@collabora.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).