From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Luis Alberto Herrera <luisalberto@google.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
tudor.ambarus@microchip.com, Jethro Beekman <jethro@fortanix.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH] mtd: revert "spi-nor: intel: provide a range for poll_timout"
Date: Thu, 11 Jun 2020 13:39:47 +0300 [thread overview]
Message-ID: <20200611103947.GC247495@lahna.fi.intel.com> (raw)
In-Reply-To: <20200610224652.64336-1-luisalberto@google.com>
On Wed, Jun 10, 2020 at 10:46:49PM +0000, Luis Alberto Herrera wrote:
> This change reverts aba3a882a178: "mtd: spi-nor: intel: provide a range
> for poll_timout". That change introduces a performance regression when
> reading sequentially from flash. Logging calls to intel_spi_read without
> this change we get:
>
> Start MTD read
> [ 20.045527] intel_spi_read(from=1800000, len=400000)
> [ 20.045527] intel_spi_read(from=1800000, len=400000)
> [ 282.199274] intel_spi_read(from=1c00000, len=400000)
> [ 282.199274] intel_spi_read(from=1c00000, len=400000)
> [ 544.351528] intel_spi_read(from=2000000, len=400000)
> [ 544.351528] intel_spi_read(from=2000000, len=400000)
> End MTD read
>
> With this change:
>
> Start MTD read
> [ 21.942922] intel_spi_read(from=1c00000, len=400000)
> [ 21.942922] intel_spi_read(from=1c00000, len=400000)
> [ 23.784058] intel_spi_read(from=2000000, len=400000)
> [ 23.784058] intel_spi_read(from=2000000, len=400000)
> [ 25.625006] intel_spi_read(from=2400000, len=400000)
> [ 25.625006] intel_spi_read(from=2400000, len=400000)
> End MTD read
>
> Signed-off-by: Luis Alberto Herrera <luisalberto@google.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-06-11 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 22:46 [PATCH] mtd: revert "spi-nor: intel: provide a range for poll_timout" Luis Alberto Herrera
2020-06-11 10:39 ` Mika Westerberg [this message]
2020-06-26 10:57 ` Tudor.Ambarus
2020-07-22 16:37 ` Alexander Sverdlin
2020-07-22 17:03 ` Tudor.Ambarus
2020-07-23 9:05 ` Alexander Sverdlin
2020-07-28 8:28 ` Tudor.Ambarus
2020-07-28 9:55 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611103947.GC247495@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bbrezillon@kernel.org \
--cc=jethro@fortanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=luisalberto@google.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).