From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C28CC433DF for ; Wed, 22 Jul 2020 14:37:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14FA220771 for ; Wed, 22 Jul 2020 14:37:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zAxG9wSu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14FA220771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BR9644FtCP7dUdfR6HOEA864om4rAEXwa5AtxfJNRRo=; b=zAxG9wSuvxr3ENE8alEwjZpGy gcIfHdqtLPFlyPMYR52Y091fUUjC7RVj+4aPsKPwVEDwzOcSMRSMX/uDM3XhQ8bpZB9AJrr/e5IiK 1l1BBxunSbwBNecs7txblMvk78ToZXptbq/nV4FUFb8CpW6gBf1wXUqBYlXaTx9vSxNbYXU26aX1R HyGx7hwcCoW5lDdXLMAzzODDFFgDb5/2UmgkkWXoXQeqvjUhjHnJGGNhzrUxGpil0/OUxrdYGXSrc Ro5PUGlXrFaVv5VguZhr+UHzEfr448Kg6jljHCblD1LG3iuH/2SePABhgOqFB10PAeo5TO8OjPP1+ N2rYSLcSQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyFqy-0005au-By; Wed, 22 Jul 2020 14:36:16 +0000 Received: from mga02.intel.com ([134.134.136.20]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyFqu-0005ZL-DJ for linux-mtd@lists.infradead.org; Wed, 22 Jul 2020 14:36:14 +0000 IronPort-SDR: utOwU7WuX+kQ5zhSrqb+wK0/8OSuubvFhVj20VIOtuTR7MNPv+wKTM7G6iU+bCaAtSVPNf26JE hYZ/swxiDdzw== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="138416750" X-IronPort-AV: E=Sophos;i="5.75,383,1589266800"; d="scan'208";a="138416750" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2020 07:36:08 -0700 IronPort-SDR: 0fDA+wFM2VhH/FNuai2oBdG5m5IqSLN3WBVI03QvuIPscpFFKfhz8xwTE0a1wZJbBU1K9LeRhM TUEYRGTotjNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,383,1589266800"; d="scan'208";a="392692686" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 22 Jul 2020 07:36:05 -0700 Received: by lahna (sSMTP sendmail emulation); Wed, 22 Jul 2020 17:36:04 +0300 Date: Wed, 22 Jul 2020 17:36:04 +0300 From: Mika Westerberg To: Tudor.Ambarus@microchip.com Subject: Re: [PATCH] mtd: spi-nor: intel-spi: Simulate WRDI command Message-ID: <20200722143604.GQ5180@lahna.fi.intel.com> References: <282e1305-fd08-e446-1a22-eb4dff78cfb4@nokia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_103612_608044_01BF404D X-CRM114-Status: GOOD ( 23.47 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ibr@ilbers.de, linux-mtd@lists.infradead.org, alexander.sverdlin@nokia.com, vigneshr@ti.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jul 22, 2020 at 02:28:30PM +0000, Tudor.Ambarus@microchip.com wrote: > + Mika > > Hi, Mika, > > Would you please review the patch from below? Sure, there is minor comment below. > > Thanks! > > On 7/22/20 5:01 PM, Alexander Sverdlin wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > From: Alexander Sverdlin > > > > After spi_nor_write_disable() return code checks were introduced in the > > spi-nor front end intel-spi backend stopped to work because WRDI was never > > supported and always failed. > > > > Just pretend it was sucessful and ignore the command itself. HW sequencer > > shall do the right thing automatically, while with SW sequencer we cannot > > do it anyway, because the only tool we had was preopcode and it makes no > > sense for WRDI. > > > > Cc: stable@vger.kernel.org > > Fixes: bce679e5ae3a ("mtd: spi-nor: Check for errors after each Register Operation") > > Signed-off-by: Alexander Sverdlin > > --- > > drivers/mtd/spi-nor/controllers/intel-spi.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/mtd/spi-nor/controllers/intel-spi.c b/drivers/mtd/spi-nor/controllers/intel-spi.c > > index 61d2a0a..134b356 100644 > > --- a/drivers/mtd/spi-nor/controllers/intel-spi.c > > +++ b/drivers/mtd/spi-nor/controllers/intel-spi.c > > @@ -612,6 +612,14 @@ static int intel_spi_write_reg(struct spi_nor *nor, u8 opcode, const u8 *buf, > > return 0; > > } > > > > + /* > > + * We hope that HW sequencer will do the right thing automatically and > > + * with the SW seuencer we cannot use preopcode any way, so just ignore ^^^^^^^^ Typo, should be sequencer. Otherwise looks good to me. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/