From: Marco Felsch <m.felsch@pengutronix.de>
To: tudor.ambarus@microchip.com, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com,
sergei.shtylyov@cogentembedded.com,
boris.brezillon@collabora.com, michael@walle.cc,
j.neuschaefer@gmx.net
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: [PATCH 2/3] mtd: spi-nor: sst: add missing write_enable
Date: Fri, 11 Sep 2020 16:47:02 +0200 [thread overview]
Message-ID: <20200911144703.25409-3-m.felsch@pengutronix.de> (raw)
In-Reply-To: <20200911144703.25409-1-m.felsch@pengutronix.de>
According the datasheet [1] the WEL is automatically reset after the
Byte-Program instruction completion. So if we program the device with
byte-size set to 32 and starting from an odd address only the first and
the last byte is written. Fix this by (re-)anble the write support for
the first SPINOR_OP_AAI_WP sequence.
[1] http://ww1.microchip.com/downloads/en/DeviceDoc/20005044C.pdf;
"4.3.2 WRITE ENABLE LATCH (WEL)"
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
drivers/mtd/spi-nor/sst.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
index e0af6d25d573..644252e27a2a 100644
--- a/drivers/mtd/spi-nor/sst.c
+++ b/drivers/mtd/spi-nor/sst.c
@@ -79,6 +79,13 @@ static int sst_write(struct mtd_info *mtd, loff_t to, size_t len,
/* Write out most of the data here. */
for (; actual < len - 1; actual += 2) {
+ /* Enable write support if odd address was written before */
+ if (actual == 1) {
+ ret = spi_nor_write_enable(nor);
+ if (ret)
+ goto out;
+ }
+
nor->program_opcode = SPINOR_OP_AAI_WP;
/* write two bytes. */
--
2.20.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-09-11 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 14:47 [PATCH 0/3] MTD: SST SPI-NOR fixes Marco Felsch
2020-09-11 14:47 ` [PATCH 1/3] mtd: spi-nor: sst: fix write support for SST_WRITE marked devices Marco Felsch
2020-09-14 12:00 ` Vignesh Raghavendra
2020-09-16 9:36 ` Tudor.Ambarus
2020-09-11 14:47 ` Marco Felsch [this message]
2020-09-11 14:47 ` [PATCH 3/3] mtd: spi-nor: sst: move sst_write_second to local driver Marco Felsch
2020-11-24 20:35 ` [PATCH 0/3] MTD: SST SPI-NOR fixes Michael Auchter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911144703.25409-3-m.felsch@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=boris.brezillon@collabora.com \
--cc=j.neuschaefer@gmx.net \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).