* [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe"
@ 2020-10-05 9:03 Vignesh Raghavendra
2020-10-05 14:43 ` Doug Anderson
2020-10-06 5:23 ` Vignesh Raghavendra
0 siblings, 2 replies; 3+ messages in thread
From: Vignesh Raghavendra @ 2020-10-05 9:03 UTC (permalink / raw)
To: Vignesh Raghavendra
Cc: linux-kernel, Michael Walle, linux-mtd, Doug Anderson, Tudor Ambarus
This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.
This leads to warn dump like [1] on some platforms and reorders MTD
devices thus may break user space expectations. So revert the change.
[1]:
[ 1.849801] ------------[ cut here ]------------
[ 1.854271] mscc_felix 0000:00:00.5: device is disabled, skipping
[ 1.858753] WARNING: CPU: 1 PID: 7 at kernel/kmod.c:136 __request_module+0x3a4/0x568
[...]
Reported-by: Michael Walle <michael@walle.cc>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
drivers/mtd/spi-nor/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index 2add4a01fce2..0369d98b2d12 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -3451,7 +3451,6 @@ static struct spi_mem_driver spi_nor_driver = {
.driver = {
.name = "spi-nor",
.of_match_table = spi_nor_of_table,
- .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
.id_table = spi_nor_dev_ids,
},
--
2.28.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe"
2020-10-05 9:03 [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe" Vignesh Raghavendra
@ 2020-10-05 14:43 ` Doug Anderson
2020-10-06 5:23 ` Vignesh Raghavendra
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2020-10-05 14:43 UTC (permalink / raw)
To: Vignesh Raghavendra; +Cc: Michael Walle, linux-mtd, LKML, Tudor Ambarus
Hi,
On Mon, Oct 5, 2020 at 2:03 AM Vignesh Raghavendra <vigneshr@ti.com> wrote:
>
> This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.
>
> This leads to warn dump like [1] on some platforms and reorders MTD
> devices thus may break user space expectations. So revert the change.
>
> [1]:
>
> [ 1.849801] ------------[ cut here ]------------
> [ 1.854271] mscc_felix 0000:00:00.5: device is disabled, skipping
> [ 1.858753] WARNING: CPU: 1 PID: 7 at kernel/kmod.c:136 __request_module+0x3a4/0x568
>
> [...]
>
> Reported-by: Michael Walle <michael@walle.cc>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> drivers/mtd/spi-nor/core.c | 1 -
> 1 file changed, 1 deletion(-)
Thank you for the revert and sorry for the breakage.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe"
2020-10-05 9:03 [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe" Vignesh Raghavendra
2020-10-05 14:43 ` Doug Anderson
@ 2020-10-06 5:23 ` Vignesh Raghavendra
1 sibling, 0 replies; 3+ messages in thread
From: Vignesh Raghavendra @ 2020-10-06 5:23 UTC (permalink / raw)
To: Vignesh Raghavendra
Cc: Michael Walle, Tudor Ambarus, linux-mtd, linux-kernel, Doug Anderson
On Mon, 5 Oct 2020 14:33:21 +0530, Vignesh Raghavendra wrote:
> This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.
>
> This leads to warn dump like [1] on some platforms and reorders MTD
> devices thus may break user space expectations. So revert the change.
>
> [1]:
>
> [...]
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next, thanks!
[1/1] Revert "mtd: spi-nor: Prefer asynchronous probe"
https://git.kernel.org/mtd/c/9a3422a110
--
Regards
Vignesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-06 5:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 9:03 [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe" Vignesh Raghavendra
2020-10-05 14:43 ` Doug Anderson
2020-10-06 5:23 ` Vignesh Raghavendra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).