Linux-mtd Archive on
 help / color / Atom feed
From: Miquel Raynal <>
To: Fabio Estevam <>,
Subject: Re: [PATCH v2] mtd: rawnand: ifc: Move the ECC engine initialization to the right place
Date: Mon, 26 Oct 2020 18:45:25 +0100
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 2020-10-16 at 13:26:26 UTC, Fabio Estevam wrote:
> No ECC initialization should happen during the host controller probe.
> In fact, we need the probe function to call nand_scan() in order to:
> - identify the device, its capabilities and constraints (nand_scan_ident())
> - configure the ECC engine accordingly (->attach_chip())
> - scan its content and prepare the core (nand_scan_tail())
> Moving these lines to fsl_ifc_attach_chip() fixes a regression caused by
> a previous commit supposed to clarify these steps.
> Based on a fix done for the mxc_nand driver by Miquel Raynal.
> Reported-by: Han Xu <>
> Signed-off-by: Fabio Estevam <>
> Tested-by: Han Xu <>

Applied to mtd/fixes, thanks.


Linux MTD discussion mailing list

  parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 13:26 Fabio Estevam
2020-10-19 17:15 ` [EXT] " Han Xu
2020-10-26 17:45 ` Miquel Raynal [this message]
2020-10-26 17:48   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mtd Archive on

Archives are clonable:
	git clone --mirror linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ \
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone