Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Manuel Dipolt <mdipolt@robart.cc>
Cc: Roland Ruckerbauer <rruckerbauer@robart.cc>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	maxime <maxime@cerno.tech>
Subject: Re: [PATCH v7] mtd: rawnand: sunxi: Add MDMA support
Date: Wed, 28 Oct 2020 14:42:55 +0100
Message-ID: <20201028144255.1779f855@xps13> (raw)
In-Reply-To: <154840787.280672.1602517282173.JavaMail.zimbra@robart.cc>

Hi Manuel,

Manuel Dipolt <mdipolt@robart.cc> wrote on Mon, 12 Oct 2020 17:41:22
+0200 (CEST):

> This patch enables NAND MDMA (MBUS DMA) mode for 
> the Allwinner SoCs A23/A33/H3. 
> 
> The DMA transfer method gets sets now to MBUS DMA as default for
> the sun8i-a23-nand-controller (till now DMA transfer was executed
> via the shared DMA engine).
> 
> The main advantage is more bandwidth for the users of the shared DMA
> engine and also that the MBUS DMA setup requires less configuration
> effort. For example you don't need to define a dedicated DMA channel
> in the device-tree any more.
> 
> 
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Manuel Dipolt <manuel.dipolt@robart.cc>

I tested your patch, it breaks my CHIP pro (sun5i R8):

[    1.775606] nand: device found, Manufacturer ID: 0x98, Chip ID: 0xd7
[    1.782168] nand: Toshiba TC58TEG5DCLTA00
[    1.786292] nand: 4096 MiB, MLC, erase size: 4096 KiB, page size: 16384, OOB size: 1280
[    1.798037] Scanning device for bad blocks
[    2.808728] sunxi_nand 1c03000.nand-controller: wait interrupt timedout
[    2.983031] random: fast init done
[    3.848719] sunxi_nand 1c03000.nand-controller: wait interrupt timedout
[    4.017501] random: crng init done
[    4.859050] sunxi_nand 1c03000.nand-controller: wait for empty cmd FIFO timedout
[    5.870270] sunxi_nand 1c03000.nand-controller: wait for empty cmd FIFO timedout
[    6.881406] sunxi_nand 1c03000.nand-controller: wait for empty cmd FIFO timedout
[    6.892444] nand_bbt: can't scan flash and build the RAM-based BBT
[    6.902268] sunxi_nand 1c03000.nand-controller: failed to init nand chips
[    6.912925] sunxi_nand: probe of 1c03000.nand-controller failed with error -110

I don't have the time to debug it right now, I'm sorry.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 15:41 Manuel Dipolt
2020-10-28 13:42 ` Miquel Raynal [this message]
2020-10-28 14:35 ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201028144255.1779f855@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=maxime@cerno.tech \
    --cc=mdipolt@robart.cc \
    --cc=rruckerbauer@robart.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git