From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-mtd@lists.infradead.org
Cc: kernel@pengutronix.de, Jan Kara <jack@suse.com>,
Richard Weinberger <richard@nod.at>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH 3/7] ubifs: do not call ubifs_inode() on unchecked pointer
Date: Tue, 30 Mar 2021 12:43:47 +0200 [thread overview]
Message-ID: <20210330104351.21328-4-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20210330104351.21328-1-s.hauer@pengutronix.de>
new_inode() may return NULL, so only derefence the return inode when
it's non NULL. This is merely a cleanup as calling ubifs_inode() on a
NULL pointer doesn't do any harm, only using the result would.
Nevertheless using inode only after it has been checked for validity
looks much cleaner.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
fs/ubifs/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index d9d8d7794eff..ba4944c87a2c 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -82,10 +82,10 @@ struct inode *ubifs_new_inode(struct ubifs_info *c, struct inode *dir,
bool encrypted = false;
inode = new_inode(c->vfs_sb);
- ui = ubifs_inode(inode);
if (!inode)
return ERR_PTR(-ENOMEM);
+ ui = ubifs_inode(inode);
/*
* Set 'S_NOCMTIME' to prevent VFS form updating [mc]time of inodes and
* marking them dirty in file write path (see 'file_update_time()').
--
2.29.2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-03-30 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 10:43 [PATCH v5 0/7] Add quota support to UBIFS Sascha Hauer
2021-03-30 10:43 ` [PATCH 1/7] ubifs: move checks and preparation into setflags() Sascha Hauer
2021-03-30 10:43 ` [PATCH 2/7] ubifs: Add support for FS_IOC_FS[SG]ETXATTR ioctls Sascha Hauer
2021-03-30 10:43 ` Sascha Hauer [this message]
2021-03-30 10:43 ` [PATCH 4/7] ubifs: Factor out ubifs_set_feature_flag() Sascha Hauer
2021-03-30 10:43 ` [PATCH 5/7] ubifs: Add support for project id Sascha Hauer
2021-03-30 10:43 ` [PATCH 6/7] ubifs: move get_znode() to global scope Sascha Hauer
2021-03-30 10:43 ` [PATCH 7/7] ubifs: Add quota support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330104351.21328-4-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=jack@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).