From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
<linux-mtd@lists.infradead.org>
Cc: Naga Sureshkumar Relli <nagasure@xilinx.com>,
Michal Simek <monstr@monstr.eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [RFC PATCH 03/16] mtd: rawnand: atmel: Check the proposed data interface is supported
Date: Fri, 2 Apr 2021 11:51:32 +0200 [thread overview]
Message-ID: <20210402095145.254867-4-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20210402095145.254867-1-miquel.raynal@bootlin.com>
Check the data interface is supported in ->setup_interface() before
acknowledging the timings.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/mtd/nand/raw/atmel/nand-controller.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
index 53b3a11b9952..6e15f424b071 100644
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -1524,8 +1524,13 @@ static int atmel_nand_setup_interface(struct nand_chip *chip, int csline,
const struct nand_interface_config *conf)
{
struct atmel_nand *nand = to_atmel_nand(chip);
+ const struct nand_sdr_timings *sdr;
struct atmel_nand_controller *nc;
+ sdr = nand_get_sdr_timings(conf);
+ if (IS_ERR(sdr))
+ return PTR_ERR(sdr);
+
nc = to_nand_controller(nand->base.controller);
if (csline >= nand->numcs ||
--
2.27.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-04-02 9:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 9:51 [RFC PATCH 00/16] mtd: rawnand: NV-DDR support Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 01/16] mtd: rawnand: Add a helper to clarify the interface configuration Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 02/16] mtd: rawnand: arasan: Check the proposed data interface is supported Miquel Raynal
2021-04-02 9:51 ` Miquel Raynal [this message]
2021-04-02 9:51 ` [RFC PATCH 04/16] mtd: rawnand: onfi: Use the BIT() macro when possible Miquel Raynal
2021-04-07 7:38 ` Alexander Dahl
2021-04-02 9:51 ` [RFC PATCH 05/16] mtd: rawnand: Update dead URL Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 06/16] mtd: rawnand: Use more recent ONFI specification wording Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 07/16] mtd: rawnand: Clarify the NV-DDR entries in the ONFI structure Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 08/16] mtd: rawnand: Add NV-DDR timings Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 09/16] mtd: rawnand: Retrieve NV-DDR timing modes from the ONFI parameter page Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 10/16] mtd: rawnand: Add an indirection on onfi_fill_interface_config() Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 11/16] mtd: rawnand: Add onfi_fill_nvddr_interface_config() helper Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 12/16] mtd: rawnand: Avoid accessing NV-DDR timings from legacy code Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 13/16] mtd: rawnand: Access SDR and NV-DDR timings through a common macro Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 14/16] mtd: rawnand: Add a helper to find the closest ONFI NV-DDR mode Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 15/16] mtd: rawnand: Choose the best timings, NV-DDR included Miquel Raynal
2021-04-02 9:51 ` [RFC PATCH 16/16] mtd: rawnand: arasan: Support NV-DDR interface Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402095145.254867-4-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=monstr@monstr.eu \
--cc=nagasure@xilinx.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).