From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Michael Walle <michael@walle.cc>
Cc: Helmut Grohne <helmut.grohne@intenta.de>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Naga Sureshkumar Relli <nagasure@xilinx.com>,
Michal Simek <monstr@monstr.eu>,
Amit Kumar Mahapatra <akumarma@xilinx.com>,
Srinivas Goud <sgoud@xilinx.com>,
Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Subject: Re: [PATCH v20 10/19] dt-binding: memory: pl353-smc: Convert to yaml
Date: Thu, 20 May 2021 13:31:55 +0200 [thread overview]
Message-ID: <20210520133155.02700d2c@xps13> (raw)
In-Reply-To: <fd29436201e8e5932a8a027472f1064a@walle.cc>
Hi Michael,
Michael Walle <michael@walle.cc> wrote on Thu, 20 May 2021 13:09:05
+0200:
> Am 2021-05-19 20:26, schrieb Miquel Raynal:
> [..]
>
> > +examples:
> > + - |
> > + smcc: memory-controller@e000e000 {
> > + compatible = "arm,pl353-smc-r2p1", "arm,primecell";
> > + reg = <0xe000e000 0x0001000>,
> > + <0xe1000000 0x5000000>;
> > + clock-names = "memclk", "apb_pclk";
> > + clocks = <&clkc 11>, <&clkc 44>;
> > + ranges = <0x0 0x0 0xe1000000 0x1000000 /* Nand CS region */
> > + 0x1 0x0 0xe2000000 0x2000000 /* SRAM/NOR CS0 region */
> > + 0x2 0x0 0xe4000000 0x2000000>; /* SRAM/NOR CS1 region > */
> > + #address-cells = <2>;
> > + #size-cells = <1>;
> > +
> > + nand0: nand-controller@0,0 {
>
> what about nfc (or nfc0) here? If I use this reference on my board it
> looks kinda odd:
While the node name (nand-controller@) is fixed, the label IIRC is
totally arbitrary, so any string here should do the trick. I agree that
nand0 is rather confusing and I don't like it much, just kept that for
legacy reasons (many DT declare the NAND controller and label it
"nand"). I'm fine changing that to nfc0 though, I'll update the
example.
>
> &nand {
> status = "okay";
>
> nand@0 {
> reg = <0>;
> nand-use-soft-ecc-engine;
> nand-ecc-algo = "bch";
> };
> };
>
> -michael
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-05-20 11:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 18:26 [PATCH v20 00/19] ARM Primecell PL35x support Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 01/19] dt-binding: memory: pl353-smc: Rephrase the binding Miquel Raynal
2021-05-21 1:51 ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 02/19] dt-binding: memory: pl353-smc: Document the range property Miquel Raynal
2021-05-21 1:57 ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 03/19] dt-binding: memory: pl353-smc: Drop the partitioning section Miquel Raynal
2021-05-21 1:57 ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 04/19] dt-binding: memory: pl353-smc: Describe the child reg property Miquel Raynal
2021-05-21 1:58 ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 05/19] dt-binding: memory: pl353-smc: Fix the example syntax and style Miquel Raynal
2021-05-21 1:58 ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 06/19] dt-binding: memory: pl353-smc: Drop unsupported nodes from the example Miquel Raynal
2021-05-21 1:58 ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 07/19] dt-binding: memory: pl353-smc: Fix the NAND controller node in " Miquel Raynal
2021-05-21 1:58 ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 08/19] dt-binding: memory: pl353-smc: Fix the reg property " Miquel Raynal
2021-05-21 1:55 ` Rob Herring
2021-05-27 10:26 ` Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 09/19] dt-binding: memory: pl353-smc: Detail the main reg property content Miquel Raynal
2021-05-21 1:57 ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 10/19] dt-binding: memory: pl353-smc: Convert to yaml Miquel Raynal
2021-05-20 0:18 ` Rob Herring
2021-05-20 11:09 ` Michael Walle
2021-05-20 11:31 ` Miquel Raynal [this message]
2021-05-19 18:26 ` [PATCH v20 11/19] memory: pl353-smc: Fix style Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 12/19] memory: pl353-smc: Rename goto labels Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 13/19] memory: pl353-smc: Let lower level controller drivers handle inits Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 14/19] memory: pl353-smc: Avoid useless acronyms in descriptions Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 15/19] memory: pl353-smc: Declare variables following a reverse christmas tree order Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 16/19] MAINTAINERS: Add PL353 SMC entry Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 17/19] MAINTAINERS: Add PL353 NAND controller entry Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 18/19] dt-bindings: mtd: pl353-nand: Describe this hardware controller Miquel Raynal
2021-05-20 0:18 ` Rob Herring
2021-05-20 20:56 ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 19/19] mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520133155.02700d2c@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=akumarma@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=helmut.grohne@intenta.de \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=monstr@monstr.eu \
--cc=nagasure@xilinx.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sgoud@xilinx.com \
--cc=sivadur@xilinx.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).