linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	<linux-mtd@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>,
	<devicetree@vger.kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Michal Simek <monstr@monstr.eu>,
	Naga Sureshkumar Relli <nagasure@xilinx.com>,
	Amit Kumar Mahapatra <akumarma@xilinx.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	helmut.grohne@intenta.de, Srinivas Goud <sgoud@xilinx.com>,
	Siva Durga Prasad Paladugu <sivadur@xilinx.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH v23 11/18] memory: pl353-smc: Rename goto labels
Date: Thu, 10 Jun 2021 10:20:33 +0200	[thread overview]
Message-ID: <20210610082040.2075611-12-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20210610082040.2075611-1-miquel.raynal@bootlin.com>

A goto label is better named

        do_something:

than

        out_something_to_do:

Use the former wording and really describe what the jump involves.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/memory/pl353-smc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/memory/pl353-smc.c b/drivers/memory/pl353-smc.c
index 2d20b1b2c0e3..14720430bf9e 100644
--- a/drivers/memory/pl353-smc.c
+++ b/drivers/memory/pl353-smc.c
@@ -388,7 +388,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
 	err = clk_prepare_enable(pl353_smc->memclk);
 	if (err) {
 		dev_err(&adev->dev, "Unable to enable memory clock.\n");
-		goto out_clk_dis_aper;
+		goto disable_axi_clk;
 	}
 
 	amba_set_drvdata(adev, pl353_smc);
@@ -408,7 +408,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
 	}
 	if (!match) {
 		dev_err(&adev->dev, "no matching children\n");
-		goto out_clk_disable;
+		goto disable_mem_clk;
 	}
 
 	init = match->data;
@@ -418,9 +418,9 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
 
 	return 0;
 
-out_clk_disable:
+disable_mem_clk:
 	clk_disable_unprepare(pl353_smc->memclk);
-out_clk_dis_aper:
+disable_axi_clk:
 	clk_disable_unprepare(pl353_smc->aclk);
 
 	return err;
-- 
2.27.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2021-06-10  8:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10  8:20 [PATCH v23 00/18] ARM Primecell PL35x support Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 01/18] dt-binding: memory: pl353-smc: Rephrase the binding Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 02/18] dt-binding: memory: pl353-smc: Document the range property Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 03/18] dt-binding: memory: pl353-smc: Drop the partitioning section Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 04/18] dt-binding: memory: pl353-smc: Describe the child reg property Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 05/18] dt-binding: memory: pl353-smc: Fix the example syntax and style Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 06/18] dt-binding: memory: pl353-smc: Drop unsupported nodes from the example Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 07/18] dt-binding: memory: pl353-smc: Fix the NAND controller node in " Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property Miquel Raynal
2021-06-10 15:53   ` Rob Herring
2021-06-10 16:01     ` Miquel Raynal
2021-06-10 21:12       ` Krzysztof Kozlowski
2021-06-10  8:20 ` [PATCH v23 09/18] dt-binding: memory: pl353-smc: Convert to yaml Miquel Raynal
2021-06-10 15:44   ` Rob Herring
2021-06-10  8:20 ` [PATCH v23 10/18] memory: pl353-smc: Fix style Miquel Raynal
2021-06-10  8:20 ` Miquel Raynal [this message]
2021-06-10  8:20 ` [PATCH v23 12/18] memory: pl353-smc: Let lower level controller drivers handle inits Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 13/18] memory: pl353-smc: Avoid useless acronyms in descriptions Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 14/18] memory: pl353-smc: Declare variables following a reverse christmas tree order Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 15/18] MAINTAINERS: Add PL353 SMC entry Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 16/18] MAINTAINERS: Add PL353 NAND controller entry Miquel Raynal
2021-06-11 19:02   ` Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 17/18] dt-bindings: mtd: pl353-nand: Describe this hardware controller Miquel Raynal
2021-06-10  8:48   ` Krzysztof Kozlowski
2021-06-10  8:56     ` Miquel Raynal
2021-06-10 15:48       ` Rob Herring
2021-06-10 15:49   ` Rob Herring
2021-06-11 19:01   ` Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 18/18] mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller Miquel Raynal
2021-06-11 19:01   ` Miquel Raynal
2021-06-10 15:21 ` [PATCH v23 00/18] ARM Primecell PL35x support Krzysztof Kozlowski
2021-06-10 15:24 ` Krzysztof Kozlowski
2021-06-10 21:09 ` (subset) " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610082040.2075611-12-miquel.raynal@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=akumarma@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=helmut.grohne@intenta.de \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=monstr@monstr.eu \
    --cc=nagasure@xilinx.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=sgoud@xilinx.com \
    --cc=sivadur@xilinx.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    --subject='Re: [PATCH v23 11/18] memory: pl353-smc: Rename goto labels' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).