From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A16C48BE5 for ; Tue, 15 Jun 2021 20:21:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C5FE613B1 for ; Tue, 15 Jun 2021 20:21:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C5FE613B1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kP0GiBW4JAjzAGn3/6m8YPd333rm28qNxycd+Eh3FRE=; b=XDnFzvkvHFXUxB veuSMqA9kl8ckhfURG3DUqY2XoaQub4PzZ8EmpRCUo8n2WN9ecYXP46zBMAjDfoul1n8Nbz2ZIimX NhB/dlWmjXCyoW0VIZoQtiHHi6Y58x4Thf/TezvjgLetqOdMF+qyPuOXaU9BcqG79yBdOcbQCvjRa 5IPLtSmEuG+jNAzNkp9WXCxAzLNPfVAD8/mlR1PkgLCsRFsOkRZ7QmMJOh+0cgXZdxhemT3yvtHBQ e3QzrvJcXZJeIy+VNksNMXjrSxmnmPKaAscjLeSAfHwUYsULrNdO28iF+OGmLT1LFp+slfi71XYbk h1LlK4xY0APcTA2azT7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltFXy-002kbK-Cw; Tue, 15 Jun 2021 20:20:30 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltBSJ-001ARZ-FC for linux-mtd@lists.infradead.org; Tue, 15 Jun 2021 15:58:24 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 757AD67373; Tue, 15 Jun 2021 17:58:17 +0200 (CEST) Date: Tue, 15 Jun 2021 17:58:17 +0200 From: Christoph Hellwig To: Marek Szyprowski Cc: Christoph Hellwig , Jens Axboe , Justin Sanders , Denis Efremov , Josef Bacik , Tim Waugh , Geoff Levand , Ilya Dryomov , "Md. Haris Iqbal" , Jack Wang , "Michael S. Tsirkin" , Jason Wang , Konrad Rzeszutek Wilk , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Mike Snitzer , Maxim Levitsky , Alex Dubov , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , dm-devel@redhat.com, linux-block@vger.kernel.org, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org, Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 09/30] mtd_blkdevs: use blk_mq_alloc_disk Message-ID: <20210615155817.GA31047@lst.de> References: <20210602065345.355274-1-hch@lst.de> <20210602065345.355274-10-hch@lst.de> <13b21a07-b7c7-37db-fdc9-77bf174b6f8f@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <13b21a07-b7c7-37db-fdc9-77bf174b6f8f@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_085823_762099_751FEAB0 X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, Jun 15, 2021 at 05:47:44PM +0200, Marek Szyprowski wrote: > Hi, > > On 02.06.2021 08:53, Christoph Hellwig wrote: > > Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue > > allocation. > > > > Signed-off-by: Christoph Hellwig > > This patch landed in linux-next as commit 6966bb921def ("mtd_blkdevs: > use blk_mq_alloc_disk"). It causes the following regression on my QEMU > arm64 setup: Please try the patch below: diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 5dc4c966ea73..6ce4bc57f919 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -382,6 +382,7 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new) } new->disk = gd; + new->rq = new->disk->queue; gd->private_data = new; gd->major = tr->major; gd->first_minor = (new->devnum) << tr->part_bits; ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/