Re: [PATCH v7 0/4] mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hello,

regressions@leemhuis.info wrote on Sun, 10 Apr 2022 10:51:17 +0200:

> Hi, this is your Linux kernel regression tracker. Top-posting for once,
> to make this easily accessible to everyone.
> 
> Miquel, Richard, Vignesh: what's up here? This patchset fixes a
> regression. It's quite old, so it's not that urgent, but it looked like
> nothing happened for two and a half week now. Or was progress made
> somewhere?

Vignesh, I'm waiting for your review/ack ;)

> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

Nice 'tool' :)

> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> reports on my table. I can only look briefly into most of them and lack
> knowledge about most of the areas they concern. I thus unfortunately
> will sometimes get things wrong or miss something important. I hope
> that's not the case here; if you think it is, don't hesitate to tell me
> in a public reply, it's in everyone's interest to set the public record
> straight.
> 
> #regzbot poke
> 
> On 23.03.22 18:04, Tokunori Ikegami wrote:
> > Since commit dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to
> > check correct value") buffered writes fail on S29GL064N. This is
> > because, on S29GL064N, reads return 0xFF at the end of DQ polling for
> > write completion, where as, chip_good() check expects actual data
> > written to the last location to be returned post DQ polling completion.
> > Fix is to revert to using chip_good() for S29GL064N which only checks
> > for DQ lines to settle down to determine write completion.
> > 
> > Fixes: dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to check correct value")
> > Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
> > Cc: stable@vger.kernel.org
> > Link: https://lore.kernel.org/r/b687c259-6413-26c9-d4c9-b3afa69ea124@pengutronix.de/
> > 
> > Tokunori Ikegami (4):
> >   mtd: cfi_cmdset_0002: Move and rename
> >     chip_check/chip_ready/chip_good_for_write
> >   mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N
> >   mtd: cfi_cmdset_0002: Add S29GL064N ID definition
> >   mtd: cfi_cmdset_0002: Rename chip_ready variables
> > 
> >  drivers/mtd/chips/cfi_cmdset_0002.c | 112 ++++++++++++++--------------
> >  include/linux/mtd/cfi.h             |   1 +
> >  2 files changed, 55 insertions(+), 58 deletions(-)
> >   
> 


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/