From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21E3CC433EF for ; Wed, 29 Jun 2022 07:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2+y4pT07nbXFvOrqM4Ji3ws8IeQoiQde8YKW92WuUFY=; b=tlpejZDuBUwKIabp6h472S8tEy zzdHLngszcPQcBIv3P9we0fXNHcam3GfRBfXX/WTbgxz6r/ARrNf4ZJBJHIk/+pe07L7Ha7bGJKYO EXmZjf1SY/byA1jWha+XqfYJr1RUO2L+LsbxL5ZLgyZYzx9bzcMZzJwXGGAeiArVDx1uxBKGPjzNL W1yc9fWBrN/BNqjgxYRF2Uqb7lhOBV2bCoIMj315tQFP3jov03w8h593ud6Rk9crjkKFnoqPuoyJT +oAiL+VRoHcI3nIX1+biB06SYiC38hGGZsnRxEZgJXCWLR5UrZC0nv2ATfi6MtKDuz+gxzM1+Hq/9 f018BL6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6SND-00AB6R-I2; Wed, 29 Jun 2022 07:44:31 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6SN9-00AB3n-3h for linux-mtd@lists.infradead.org; Wed, 29 Jun 2022 07:44:29 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6SMS-0000bz-Te; Wed, 29 Jun 2022 09:43:44 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o6SMM-003M5u-8n; Wed, 29 Jun 2022 09:43:41 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o6SMO-001qhO-2i; Wed, 29 Jun 2022 09:43:40 +0200 Date: Wed, 29 Jun 2022 09:43:37 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Crt Mori Cc: Andrew Lunn , Ricardo Ribalda , Jimmy Su , Benjamin Herrenschmidt , Linus Walleij , Sekhar Nori , Gwendal Grignou , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Benjamin Tissoires , Paul Mackerras , Minghao Chi , Pavel Machek , Miquel Raynal , Heikki Krogerus , Evgeniy Polyakov , Matt Johnston , Olli Salonen , Angela Czubak , Robert Marko , Luka Perkov , Sean Young , Dave Stevenson , Michael Ellerman , Zheyu Ma , Javier Martinez Canillas , Christophe Leroy , Chanwoo Choi , linux-omap@vger.kernel.org, Antti Palosaari , Wenyou Yang , Dongchun Zhu , Miaoqian Lin , Steve Longerbeam , Bingbu Cao , Shunqian Zheng , lijian , Dan Carpenter , Bartlomiej Zolnierkiewicz , Viorel Suman , Petr Machata , Guido =?utf-8?Q?G=C3=BCnther?= , Jean Delvare , linux-serial@vger.kernel.org, linux-pm@vger.kernel.org, linux-mtd@lists.infradead.org, Eddie James , Riku Voipio , James Schulman , Scott Wood , Cai Huoqing , Jonas Malaco , Hsin-Yi Wang , Haibo Chen , Petr Cvek , linux-leds@vger.kernel.org, Joe Tessler , Andrey Konovalov , Andy Shevchenko , Robert Jones , George Joseph , Vincent Knecht , Robin van der Gracht , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, Michael Tretter , Geert Uytterhoeven , Phong LE , Daniel Beer , Krzysztof Opasiak , Bjorn Andersson , linux-crypto@vger.kernel.org, Pengutronix Kernel Team , Heungjun Kim , Hans Verkuil , David Lin , Vladimir Oltean , David Rhodes , Claudiu Beznea , Arnaud Ferraris , Jean-Baptiste Maneyrol , Alexandre Belloni , Dan Robertson , Martyn Welch , Jiri Slaby , devicetree@vger.kernel.org, David Airlie , Jon Nettleton , Srinivas Pandruvada , Marco Felsch , Wim Van Sebroeck , Sebastian Reichel , Max Filippov , "Lad, Prabhakar" , Thierry Reding , linux-i2c@vger.kernel.org, Martiros Shakhzadyan , Guenter Roeck , Matthias Schwarzott , Sylwester Nawrocki , Dmitry Rokosov , Marek =?utf-8?B?QmVow7pu?= , Saranya Gopal , Lars-Peter Clausen , Corey Minyard , Evgeny Novikov , Frank Rowand , Bartosz Golaszewski , Manivannan Sadhasivam , Pierre-Louis Bossart , Eric Dumazet , linux-clk@vger.kernel.org, Nathan Chancellor , alsa-devel@alsa-project.org, MyungJoo Ham , Charles Gorand , Jagan Teki , Vijendar Mukunda , Miguel Ojeda , Kyungmin Park , Tianshu Qiu , Martin Donnelly , Woojung Huh , Rudolf Marek , Charles Keepax , linux-watchdog@vger.kernel.org, Michael Hennerich , Ido Schimmel , acpi4asus-user@lists.sourceforge.net, Simon Trimmer , Ricard Wanderlof , Rikard Falkeborn , Alex Deucher , wengjianfeng , Jiri Valek - 2N , linux-rpi-kernel@lists.infradead.org, Biju Das , Wayne Chang , Chen-Yu Tsai , Sing-Han Chen , linux-arm-kernel@lists.infradead.org, Niklas =?utf-8?Q?S=C3=B6derlund?= , Hans de Goede , Stephen Boyd , Maslov Dmitry , linux-gpio@vger.kernel.org, Jens Frederich , Douglas Anderson , Peter Rosin , Wolfram Sang , Jarkko Sakkinen , linux-usb@vger.kernel.org, Jacopo Mondi , Maxime Coquelin , CGEL ZTE , Colin Leroy , platform-driver-x86@vger.kernel.org, linux-integrity@vger.kernel.org, Kevin Tsai , Pali =?utf-8?B?Um9ow6Fy?= , Jonathan Cameron , Heiner Kallweit , Arec Kao , Stephen Kitt , Jose Cazarin , Neil Armstrong , linux-iio@vger.kernel.org, Tom Rix , Michael Turquette , Peter Senna Tschudin , Benjamin Mugnier , Nuno =?utf-8?B?U8Oh?= , Jan-Simon Moeller , Wei Yongjun , Laurent Pinchart , Andrzej Hajda , Nikita Travkin , Jeremy Kerr , Jasmin Jessich , Sam Ravnborg , Kevin Cernekee , Alyssa Rosenzweig , linux-rtc@vger.kernel.org, Daniel Thompson , Florian Fainelli , Lucas Tanure , Stefan Mavrodiev , Masahiro Yamada , Sylvain Petinot , netdev@vger.kernel.org, Kieran Bingham , Jernej Skrabec , Xin Ji , Seven Lee , Matt Ranostay , Broadcom internal kernel review list , Adrien Grassein , Yang Yingliang , chrome-platform@lists.linux.dev, Mats Randgaard , Paolo Abeni , Alexey Dobriyan , Joel Stanley , linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Lyude Paul , Kees Cook , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jonas Karlman , Yang Li , Tim Harvey , Jiri Kosina , Akinobu Mita , Mark Gross , Richard Fitzgerald , Mark Brown , linux-media@vger.kernel.org, Maxime Ripard , Sven Peter , Martin Kepplinger , openipmi-developer@lists.sourceforge.net, Mauro Carvalho Chehab , Benson Leung , "Daniel W. S. Almeida" , Chiranjeevi Rapolu , Alessandro Zummo , linux-hwmon@vger.kernel.org, Felipe Balbi , Stephan Gerhold , Support Opensource , Alexandru Ardelean , Dmitry Torokhov , Marc Hulsman , Corentin Chary , linux-fbdev@vger.kernel.org, Daniel Scally , Andrey Ryabinin , Arnd Bergmann , Kirill Shilimanov , Sakari Ailus , patches@opensource.cirrus.com, Zheng Yongjun , Alejandro Tafalla , "David S. Miller" , Daniel Palmer , Hector Martin , Moses Christopher Bollavarapu , Vignesh Raghavendra , Nick Dyer , Greg Kroah-Hartman , Tony Lindgren , Alexandre Torgue , Takashi Iwai , Paul Cercueil , George McCollister , Mac Chiang , Antoniu Miclaus , Alexander Potapenko , Adam Ford , Peter Huewe , UNGLinuxDriver@microchip.com, Lee Jones , Alexey Khoroshilov , Marek Vasut , Paul Kocialkowski , Vincenzo Frascino , Eric Piel , Herbert Xu , Tobias Schrammm , Richard Weinberger , Tomasz Duszynski , Janusz Krzysztofik , Russell King , linux-pwm@vger.kernel.org, Jason Gunthorpe , Thomas Zimmermann , Bastien Nocera , Jingoo Han , Jakub Kicinski , Vivien Didelot , Yizhuo , Shawn Tu , Leon Luo , Yan Lei , Akihiro Tsukada , Tudor Ambarus , Oliver Graute , Alistair Francis , Dongliang Mu , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Eduardo Valentin , Rui Miguel Silva , Michael Srba , Rob Herring , linux-mediatek@lists.infradead.org, Fabio Estevam , Matthias Brugger , kasan-dev@googlegroups.com, "Paul J. Murphy" , Nicola Lunghi , Daniele Alessandrelli , Dmitry Vyukov , Ramesh Shanmugasundaram , Liam Girdwood , Juerg Haefliger , Oder Chiou , Shengjiu Wang , Nicolas Ferre , Robert Foss , Krzysztof Kozlowski , Daniel Vetter , Alvin =?utf-8?Q?=C5=A0ipraga?= , Luca Ceresoli , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= , Johannes Berg , Colin Ian King , Maximilian Luz , Helge Deller , linux-staging@lists.linux.dev, Lucas Stach Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220629074337.mks23y5rt6c536wl@pengutronix.de> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_004427_528154_538E8F94 X-CRM114-Status: GOOD ( 24.01 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2007070611473336912==" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org --===============2007070611473336912== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="udaf7kclxozlbsvv" Content-Disposition: inline --udaf7kclxozlbsvv Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Wed, Jun 29, 2022 at 09:24:55AM +0200, Crt Mori wrote: > On Tue, 28 Jun 2022 at 16:04, Uwe Kleine-K=F6nig > wrote: > > static const struct i2c_device_id mlx90614_id[] =3D { > > diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperatu= re/mlx90632.c > > index 7ee7ff8047a4..e8ef47147e2b 100644 > > --- a/drivers/iio/temperature/mlx90632.c > > +++ b/drivers/iio/temperature/mlx90632.c > > @@ -924,7 +924,7 @@ static int mlx90632_probe(struct i2c_client *client, > > return iio_device_register(indio_dev); > > } > > > > -static int mlx90632_remove(struct i2c_client *client) > > +static void mlx90632_remove(struct i2c_client *client) > > { > > struct iio_dev *indio_dev =3D i2c_get_clientdata(client); > > struct mlx90632_data *data =3D iio_priv(indio_dev); > > @@ -936,8 +936,6 @@ static int mlx90632_remove(struct i2c_client *clien= t) > > pm_runtime_put_noidle(&client->dev); > > > > mlx90632_sleep(data); > > - > > - return 0; > > } > > > For both mlx drivers >=20 > Reviewed-by: "Crt Mori " Thanks, it was more complicated than (IMHO) necessary to find these lines. I suggest to strip the irrelevant part the quoted mail for the next time. I added your tag without the quotes to my tree. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --udaf7kclxozlbsvv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmK8AqYACgkQwfwUeK3K 7Am8Mwf+IBff11UStG2Xle0ayEs0RLJMDDLQ5ZsJcINntMkiJCCyvH1HrHqcvTWo BtqcH/0oNBe5ko1loRbRALlOyYe7r1Q7508Zv+qkQf4Y8DOUmzWtlruJlDlo/HwV DqiQBR0Ccfi3rbtXz0hWtvpecZWbgaQd9E/ZiIunLKUo3QcVz8lf+5jLQIZgy5EM reJKul9dQD15zMfxqR2qzIVJIT1EK3OVYfO9Q0siHiTLkJ1EoQtEpW/nGYsZcKbj OXsaiHqv4yt5atJH7kx1PzmSggDluMwRWcKmTrnQTrOTD766dAE3bxP2z1V8FUTn HkMp469vyvmib6S/lNJi+NYdz9jcJw== =41Qj -----END PGP SIGNATURE----- --udaf7kclxozlbsvv-- --===============2007070611473336912== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ --===============2007070611473336912==--