From: Miquel Raynal <miquel.raynal@bootlin.com>
To: <Tudor.Ambarus@microchip.com>
Cc: <richard@nod.at>, <vigneshr@ti.com>, <peda@axentia.se>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Claudiu.Beznea@microchip.com>, <bbrezillon@kernel.org>,
<linux-mtd@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] mtd: rawnand: atmel: Unmap streaming DMA mappings
Date: Mon, 19 Sep 2022 17:29:28 +0200 [thread overview]
Message-ID: <20220919172928.6f918ab2@xps-13> (raw)
In-Reply-To: <86158844-b314-bee8-c5b8-0b757c6b6ab0@microchip.com>
Hello Tudor,
Tudor.Ambarus@microchip.com wrote on Wed, 7 Sep 2022 09:06:39 +0000:
> On 7/28/22 10:40, Tudor Ambarus wrote:
> > Every dma_map_single() call should have its dma_unmap_single() counterpart,
> > because the DMA address space is a shared resource and one could render the
> > machine unusable by consuming all DMA addresses.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
> > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> > ---
> > drivers/mtd/nand/raw/atmel/nand-controller.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> > index 6ef14442c71a..330d2dafdd2d 100644
> > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> > @@ -405,6 +405,7 @@ static int atmel_nand_dma_transfer(struct atmel_nand_controller *nc,
> >
> > dma_async_issue_pending(nc->dmac);
> > wait_for_completion(&finished);
> > + dma_unmap_single(nc->dev, buf_dma, len, dir);
> >
> > return 0;
> >
>
> Hi, Richard, Miquel,
>
> Would you please consider to include this patch in your queue?
I'm catching up only now so as we're at -rc6 and I want things to lay a
bit in -next I don't plan to send a Fixes PR, all the fixes
exceptionally will go through the usual PR as anyway they won't be
ready before the merge window opens.
> If yes, please add the following tag, it solves a regression:
>
> Link: https://lore.kernel.org/lkml/13c6c9a2-6db5-c3bf-349b-4c127ad3496a@axentia.se/
Ok.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-09-19 15:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 7:40 [PATCH] mtd: rawnand: atmel: Unmap streaming DMA mappings Tudor Ambarus
2022-07-29 10:59 ` Alexander Dahl
2022-08-09 6:28 ` Alexander Dahl
2022-08-02 11:03 ` Tudor.Ambarus
2022-08-16 9:09 ` Boris Brezillon
2022-08-17 9:28 ` Thorsten Leemhuis
2022-08-21 14:45 ` Peter Rosin
2022-09-07 9:06 ` Tudor.Ambarus
2022-09-19 15:29 ` Miquel Raynal [this message]
2022-09-20 8:10 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919172928.6f918ab2@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=peda@axentia.se \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).