From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <qemu-devel@nongnu.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
<linux-erofs@lists.ozlabs.org>, <ocfs2-devel@oss.oracle.com>,
<linux-mtd@lists.infradead.org>, <amd-gfx@lists.freedesktop.org>
Cc: <gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<somlo@cmu.edu>, <mst@redhat.com>, <jaegeuk@kernel.org>,
<chao@kernel.org>, <hsiangkao@linux.alibaba.com>,
<huangjianan@oppo.com>, <mark@fasheh.com>, <jlbec@evilplan.org>,
<joseph.qi@linux.alibaba.com>, <akpm@linux-foundation.org>,
<alexander.deucher@amd.com>, <luben.tuikov@amd.com>,
<richard@nod.at>, <liushixin2@huawei.com>
Subject: [PATCH 08/11] erofs: fix possible memory leak in erofs_init_sysfs()
Date: Fri, 21 Oct 2022 10:20:59 +0800 [thread overview]
Message-ID: <20221021022102.2231464-9-yangyingliang@huawei.com> (raw)
In-Reply-To: <20221021022102.2231464-1-yangyingliang@huawei.com>
Inject fault while loading module, kset_register() may fail,
if it fails, but the refcount of kobject is not decreased to
0, the name allocated in kobject_set_name() is leaked. Fix
this by calling kset_put(), so that name can be freed in
callback function kobject_cleanup().
unreferenced object 0xffff888101d228c0 (size 8):
comm "modprobe", pid 276, jiffies 4294722700 (age 13.151s)
hex dump (first 8 bytes):
65 72 6f 66 73 00 ff ff erofs...
backtrace:
[<00000000e2a9a4a6>] __kmalloc_node_track_caller+0x44/0x1b0
[<00000000b8ce02de>] kstrdup+0x3a/0x70
[<000000004a0e01d2>] kstrdup_const+0x63/0x80
[<00000000051b6cda>] kvasprintf_const+0x149/0x180
[<000000004dc51dad>] kobject_set_name_vargs+0x56/0x150
[<00000000b30f0bad>] kobject_set_name+0xab/0xe0
Fixes: 168e9a76200c ("erofs: add sysfs interface")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
fs/erofs/sysfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/erofs/sysfs.c b/fs/erofs/sysfs.c
index 783bb7b21b51..653b35001bc5 100644
--- a/fs/erofs/sysfs.c
+++ b/fs/erofs/sysfs.c
@@ -254,8 +254,10 @@ int __init erofs_init_sysfs(void)
kobject_set_name(&erofs_root.kobj, "erofs");
erofs_root.kobj.parent = fs_kobj;
ret = kset_register(&erofs_root);
- if (ret)
+ if (ret) {
+ kset_put(&erofs_root);
goto root_err;
+ }
ret = kobject_init_and_add(&erofs_feat, &erofs_feat_ktype,
NULL, "features");
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-10-21 2:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 2:20 [PATCH 00/11] fix memory leak while kset_register() fails Yang Yingliang
2022-10-21 2:20 ` [PATCH 01/11] kset: fix documentation for kset_register() Yang Yingliang
2022-10-21 5:34 ` Luben Tuikov
2022-10-21 8:05 ` Yang Yingliang
2022-10-21 8:16 ` Greg KH
2022-10-21 8:18 ` Luben Tuikov
2022-10-21 2:20 ` [PATCH 02/11] kset: add null pointer check in kset_put() Yang Yingliang
2022-10-21 2:20 ` [PATCH 03/11] bus: fix possible memory leak in bus_register() Yang Yingliang
2022-10-21 2:20 ` [PATCH 04/11] kobject: fix possible memory leak in kset_create_and_add() Yang Yingliang
2022-10-21 2:20 ` [PATCH 05/11] class: fix possible memory leak in __class_register() Yang Yingliang
2022-10-21 2:20 ` [PATCH 06/11] firmware: qemu_fw_cfg: fix possible memory leak in fw_cfg_build_symlink() Yang Yingliang
2022-10-21 2:20 ` [PATCH 07/11] f2fs: fix possible memory leak in f2fs_init_sysfs() Yang Yingliang
2022-10-21 2:20 ` Yang Yingliang [this message]
2022-10-21 2:21 ` [PATCH 09/11] ocfs2: possible memory leak in mlog_sys_init() Yang Yingliang
2022-10-21 2:21 ` [PATCH 10/11] drm/amdgpu/discovery: fix possible memory leak Yang Yingliang
2022-10-21 2:21 ` [PATCH 11/11] ubifs: Fix memory leak in ubifs_sysfs_init() Yang Yingliang
2022-10-21 5:29 ` [PATCH 00/11] fix memory leak while kset_register() fails Luben Tuikov
2022-10-21 5:37 ` Greg KH
2022-10-21 7:55 ` Luben Tuikov
2022-10-21 8:18 ` Greg KH
2022-10-21 8:24 ` Luben Tuikov
2022-10-21 8:41 ` Luben Tuikov
2022-10-21 9:23 ` Yang Yingliang
2022-10-21 8:24 ` Yang Yingliang
2022-10-21 8:36 ` Greg KH
2022-10-21 8:52 ` Luben Tuikov
2022-10-21 8:59 ` Yang Yingliang
2022-10-21 9:08 ` Luben Tuikov
2022-10-21 9:56 ` Yang Yingliang
2022-10-21 23:45 ` Luben Tuikov
2022-10-21 9:12 ` Yang Yingliang
2022-10-21 23:48 ` Luben Tuikov
2022-10-21 7:25 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021022102.2231464-9-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=chao@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=huangjianan@oppo.com \
--cc=jaegeuk@kernel.org \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=liushixin2@huawei.com \
--cc=luben.tuikov@amd.com \
--cc=mark@fasheh.com \
--cc=mst@redhat.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=qemu-devel@nongnu.org \
--cc=rafael@kernel.org \
--cc=richard@nod.at \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).