archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <>
To: Arnd Bergmann <>,
	Miquel Raynal <>,
	Richard Weinberger <>,
	Vignesh Raghavendra <>
Cc: Arnd Bergmann <>,, Dinghao Liu <>,,
Subject: Re: [PATCH] mtd: diskonchip: work around ubsan link failure
Date: Tue,  9 Apr 2024 08:41:27 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 2024-04-05 at 14:30:04 UTC, Arnd Bergmann wrote:
> From: Arnd Bergmann <>
> I ran into a randconfig build failure with UBSAN using gcc-13.2:
> arm-linux-gnueabi-ld: error: unplaced orphan section `.bss..Lubsan_data31' from `drivers/mtd/nand/raw/diskonchip.o'
> I'm not entirely sure what is going on here, but I suspect this has something
> to do with the check for the end of the doc_locations[] array that contains
> an (unsigned long)0xffffffff element, which is compared against the signed
> (int)0xffffffff. If this is the case, we should get a runtime check for
> undefined behavior, but we instead get an unexpected build-time error.
> I would have expected this to work fine on 32-bit architectures despite the
> signed integer overflow, though on 64-bit architectures this likely won't
> ever work.
> Changing the contition to instead check for the size of the array makes the
> code safe everywhere and avoids the ubsan check that leads to the link
> error. The loop code goes back to before 2.6.12.
> Cc:
> Signed-off-by: Arnd Bergmann <>

Applied to mtd/fixes, thanks.


Linux MTD discussion mailing list

      reply	other threads:[~2024-04-09  6:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 14:30 [PATCH] mtd: diskonchip: work around ubsan link failure Arnd Bergmann
2024-04-09  6:41 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).