From: Richard Weinberger <richard@nod.at>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled
Date: Mon, 12 Oct 2020 21:17:19 +0200 (CEST) [thread overview]
Message-ID: <2029402034.189005.1602530239737.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20201012070958.11083-1-vigneshr@ti.com>
----- Ursprüngliche Mail -----
> Von: "Vignesh Raghavendra" <vigneshr@ti.com>
> An: "Vignesh Raghavendra" <vigneshr@ti.com>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>
> CC: "Sergei Shtylyov" <sergei.shtylyov@gmail.com>, "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>
> Gesendet: Montag, 12. Oktober 2020 09:09:58
> Betreff: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled
> commit 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
> to build failure[1] with COMPILE_TEST and RPCIF_HYPERBUS enabled. This
> is because driver needs functions RENESAS_RPCIF which is only buildable
> for CONFIG_ARCH_RENESAS.
>
> Fix this by dropping COMPILE_TEST from RPCIF_HYPERBUS Kconfig entry.
> This ensures driver can be built only when RENESAS_RPCIF is also
> selected.
>
> [1]:
> rpc-if.c:(.text+0x20): undefined reference to `rpcif_disable_rpm' ld:
> drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_prepare_read':
> rpc-if.c:(.text+0xd6): undefined reference to `rpcif_prepare' ld:
> drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_read16':
> [...]
>
> Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
> Reported-by: Richard Weinberger <richard@nod.at>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
>
> Based on mtd/next
>
> Richard,
>
> Could you please pull this into mtd/next?
Applied! :-)
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-10-12 19:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 7:09 [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled Vignesh Raghavendra
2020-10-12 19:17 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2029402034.189005.1602530239737.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=sergei.shtylyov@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).