Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled
@ 2020-10-12  7:09 Vignesh Raghavendra
  2020-10-12 19:17 ` Richard Weinberger
  0 siblings, 1 reply; 2+ messages in thread
From: Vignesh Raghavendra @ 2020-10-12  7:09 UTC (permalink / raw)
  To: Vignesh Raghavendra, Miquel Raynal, Richard Weinberger
  Cc: Sergei Shtylyov, linux-mtd, linux-kernel

commit 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
to build failure[1] with COMPILE_TEST and RPCIF_HYPERBUS enabled. This
is because driver needs functions RENESAS_RPCIF which is only buildable
for CONFIG_ARCH_RENESAS.

Fix this by dropping COMPILE_TEST from RPCIF_HYPERBUS Kconfig entry.
This ensures driver can be built only when RENESAS_RPCIF is also
selected.

[1]:
rpc-if.c:(.text+0x20): undefined reference to `rpcif_disable_rpm' ld:
drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_prepare_read':
rpc-if.c:(.text+0xd6): undefined reference to `rpcif_prepare' ld:
drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_read16':
[...]

Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
Reported-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---

Based on mtd/next

Richard,

Could you please pull this into mtd/next?

 drivers/mtd/hyperbus/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/hyperbus/Kconfig b/drivers/mtd/hyperbus/Kconfig
index 35b3ab4c8b94..46c7e407e378 100644
--- a/drivers/mtd/hyperbus/Kconfig
+++ b/drivers/mtd/hyperbus/Kconfig
@@ -24,7 +24,7 @@ config HBMC_AM654
 
 config RPCIF_HYPERBUS
 	tristate "Renesas RPC-IF HyperBus driver"
-	depends on RENESAS_RPCIF || COMPILE_TEST
+	depends on RENESAS_RPCIF
 	depends on MTD_CFI_BE_BYTE_SWAP
 	help
 	  This option includes Renesas RPC-IF HyperBus support.
-- 
2.28.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled
  2020-10-12  7:09 [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled Vignesh Raghavendra
@ 2020-10-12 19:17 ` Richard Weinberger
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2020-10-12 19:17 UTC (permalink / raw)
  To: Vignesh Raghavendra
  Cc: Sergei Shtylyov, linux-mtd, linux-kernel, Miquel Raynal

----- Ursprüngliche Mail -----
> Von: "Vignesh Raghavendra" <vigneshr@ti.com>
> An: "Vignesh Raghavendra" <vigneshr@ti.com>, "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>
> CC: "Sergei Shtylyov" <sergei.shtylyov@gmail.com>, "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>
> Gesendet: Montag, 12. Oktober 2020 09:09:58
> Betreff: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled

> commit 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
> to build failure[1] with COMPILE_TEST and RPCIF_HYPERBUS enabled. This
> is because driver needs functions RENESAS_RPCIF which is only buildable
> for CONFIG_ARCH_RENESAS.
> 
> Fix this by dropping COMPILE_TEST from RPCIF_HYPERBUS Kconfig entry.
> This ensures driver can be built only when RENESAS_RPCIF is also
> selected.
> 
> [1]:
> rpc-if.c:(.text+0x20): undefined reference to `rpcif_disable_rpm' ld:
> drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_prepare_read':
> rpc-if.c:(.text+0xd6): undefined reference to `rpcif_prepare' ld:
> drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_read16':
> [...]
> 
> Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads
> Reported-by: Richard Weinberger <richard@nod.at>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> 
> Based on mtd/next
> 
> Richard,
> 
> Could you please pull this into mtd/next?

Applied! :-)

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12  7:09 [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled Vignesh Raghavendra
2020-10-12 19:17 ` Richard Weinberger

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git