From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EFE6C33CB1 for ; Thu, 16 Jan 2020 10:35:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D40852072B for ; Thu, 16 Jan 2020 10:35:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lYN8lyFi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="Ggx7JeAK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D40852072B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gCEdWiiSiWpJJs4Eaq/QnTYM2U2exmMXmUcLF7Rx/kQ=; b=lYN8lyFirBSG+t Bml3tEG/dDE/lV2zVwpyGNb+/6tF6dX7WSOML3wRU/ddES7JNKVWubjp5XwRW+6RJPAxehdjsd05g or8uaMkRWG+d9cp1h7fRGk0GuSqH8QBukBzaDJ8LRnQUlhHvrvSzErrSw9cfHwmPu0XVUfhwusVuk fqqM45cIC9cLm9pC07a4RTGtp55CCNXkIvGXMk452TtH/9zpi3IkV17y+lhc7O4/ZgNOcNDXenpWL uNBuL4ATHeEstCbJcv5nalDWb82M7Sdc33l6CONqy9TKAGmIDJ1nlk4CWVUxv7nj1cI/+PUY+t6ax qtUUlsSf3vnM6ZxMtBrQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1is2Ul-0006mJ-56; Thu, 16 Jan 2020 10:35:23 +0000 Received: from esa6.microchip.iphmx.com ([216.71.154.253]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1is2Uf-0006l4-D8 for linux-mtd@lists.infradead.org; Thu, 16 Jan 2020 10:35:21 +0000 Received-SPF: Pass (esa6.microchip.iphmx.com: domain of Tudor.Ambarus@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="Tudor.Ambarus@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com -exists:%{i}.spf.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa6.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa6.microchip.iphmx.com; spf=Pass smtp.mailfrom=Tudor.Ambarus@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: uqrbiggs4+4XPHpXusxMm+FXAcLcwcVwTmX1wa7EbTD/xtnUk1gQ/nu5/8zM9kpWu0MPnZTIiT 0Pe3uu6Eko99PhaV154Ueq0xvjqUQz7m5jdEu45KmwVRIO0xFVCDDGV9zLKJyQv9WSH4LE8zKw cmBqAtI5SdKYTRxw2HG7TLX8zqSwqH3rEwSIjlvdhBttnUIYvnJrfk73O7RziWSoCZ86KlU4de yfLiV5Cf51uNp10iY67KsrlwJVeisV9sy0l4S/5wDGrzLwa1aGq3saDme4kgA0ZxwCs4On6VA/ mx8= X-IronPort-AV: E=Sophos;i="5.70,325,1574146800"; d="scan'208";a="60985654" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 16 Jan 2020 03:35:15 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 16 Jan 2020 03:35:14 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 16 Jan 2020 03:35:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S5JoDmhcYm9sYEBL2YgtaflagW3ES9Q498LPremUh+jjVy2QRzf1uNtB74wFtSts6KQTke2moK338Pa0Otd39bhk3HrBRZO1dbewFitVP7aqPy5lHp0jIoCeLSN4vBKWXqDGvg97cf/n1fMS6DO+gUKzYR+DB9kpcDnEtG0mgPCCxn3Il+DtnidGMV3yumJoTXqvrfXCDvPhT778jBayCU0LHs4387cTT4zYgyoAjbe6qMBryhU0RN8qbSmGoYI9JnDPJjEaWiVSf6UgzYLX+2RNUNiE/PJsTQ2O9yQTxKG/jBtwJisPgja7ErLrnXq/yx0kp9yUp5LXfOuvhqnVog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eEZoMAOJ0reGsir6mlwc1NO4BDJDDZzVWJkQEqT5dKI=; b=ZblBL6yMDXyEZl1aVKVt8d6AP7Z0pevAqcRuXQSl91+DJqPx3QTnuTJL0nQrVCApc6bv1NSAvTlpDPqWWTYXfW99OVh911Jb2WxcS9JcjMnnVxVJSw2U3XGdYps5yZ+azrGsKxSr7F7XlU2dCwouDGv3WfWj8RFIPlWQbGyV1B/QVsDRiaQnUAhxX7GYpRYUsOZ0ICevG82n43U2rUWBcBONJ016sjN6ZdhZTytHxzFaKCAw1XXbOw93GPuh5sSS9yb2fPlImzh3w69ww/Nz20zP1FW+DvKvTfEUNIPghM1EZUGKVlAZgJ710Q2VQ28epxE6q0Hnic8tQOMJIGMPZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eEZoMAOJ0reGsir6mlwc1NO4BDJDDZzVWJkQEqT5dKI=; b=Ggx7JeAKZILaNEMb0CL3N4D53DkK4rOjg5+pHy1e/lx/rykQRwQB8Gp0DvG5WXLVqmc5NYZZ3lzyafaKYiqgZ53pZxsFLX8Cj9j0evQbr0185/VuIxEFJ94ZSj2oBM+26RIKw5i7+2Uf/QL/FcLAUNqoe1+AB+4uGQBpWhF7q+8= Received: from MN2PR11MB4448.namprd11.prod.outlook.com (52.135.39.157) by MN2PR11MB4286.namprd11.prod.outlook.com (52.135.38.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.20; Thu, 16 Jan 2020 10:35:13 +0000 Received: from MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::71cc:a5d4:8e1a:198b]) by MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::71cc:a5d4:8e1a:198b%7]) with mapi id 15.20.2623.018; Thu, 16 Jan 2020 10:35:13 +0000 From: To: Subject: Re: [PATCH] mtd: spi-nor: Fix quad enable for Spansion like flashes Thread-Topic: [PATCH] mtd: spi-nor: Fix quad enable for Spansion like flashes Thread-Index: AQHVzFClES9Lbc+DOUOdDHVrL3ZyDKftGJ8A Date: Thu, 16 Jan 2020 10:35:12 +0000 Message-ID: <2180698.lX2pLR0Ns3@localhost.localdomain> References: <20200116093700.28308-1-michael@walle.cc> In-Reply-To: <20200116093700.28308-1-michael@walle.cc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [94.177.32.156] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 16069c5e-84c2-4fa0-dd04-08d79a6fc4d2 x-ms-traffictypediagnostic: MN2PR11MB4286: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:386; x-forefront-prvs: 02843AA9E0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(39860400002)(136003)(366004)(346002)(199004)(189003)(66556008)(66476007)(66946007)(64756008)(66446008)(76116006)(186003)(6486002)(91956017)(86362001)(71200400001)(316002)(54906003)(2906002)(6506007)(53546011)(5660300002)(6512007)(81166006)(4326008)(8676002)(9686003)(81156014)(26005)(8936002)(478600001)(6916009)(39026012); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4286; H:MN2PR11MB4448.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fNyI3ae+g3fsRYmQlwmHycZRjvFj135VlL9hbvmUM+pMGV9nm2QWRzKihjmF8WPIbrtm7VeDWzV6l8nsEyQlsHWMnrAxSstKigH/1zt7IJMXpDOlFEP5yPEIDi5IiaJ0ZjPznwtWRdyxIRXbLE7hMkRT2tu9cMYG3n9HqXDTfA3FnNxHlt7eIEsmNwwtpRMcMp8vtxlIfvrWfxsej24+yveLzoffh6tKZKamcev/YMG/ZF/b2k//5E9Tw8a1YF8EUtztxL/dw7i0aSCNAgQc71YLHQrifpUrmNGR5Sipm1m6lLolcOeTTxFMA5H9vVMB1QjkUXsVBlw4oloSA/7KVx3zdXHRkyP51hY02fwr2VJqIo7TFhBnKqkgP2M4xN5QjTd4JqSGtVWqOIGp90R+55MKDBhxDX1NF3px0OftzcIrPJN1OmxEMwocaL0h//AuOdnu6Zv/MsQ0BINJTHe0zNyN5Jiq97rYaxQoINNmjoZe163fHdMHp/UhEARq7UJk x-ms-exchange-transport-forked: True Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 16069c5e-84c2-4fa0-dd04-08d79a6fc4d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2020 10:35:12.9266 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MgIeA4h5C3q7JvOclqzgFOM7cqmIUexMTCpdIvHFK41Pl0mwNtYl5FAxz8r2eRA0dLD6n/ehUApLOSLd6JcGM+3v5rYy8enuFhvb/v1Rd7k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4286 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200116_023517_553799_11C2F51D X-CRM114-Status: GOOD ( 10.16 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, richard@nod.at, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, miquel.raynal@bootlin.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thursday, January 16, 2020 11:37:00 AM EET Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > The commit 7b678c69c0ca ("mtd: spi-nor: Merge spansion Quad Enable > methods") forgot to actually set the QE bit in some cases. Thus this > breaks quad mode accesses to flashes which support readback of the > status register-2. Fix it. > > Fixes: 7b678c69c0ca ("mtd: spi-nor: Merge spansion Quad Enable methods") > Signed-off-by: Michael Walle Reviewed-by: Tudor Ambarus Thanks, Michael! > --- > drivers/mtd/spi-nor/spi-nor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index addb6319fcbb..ea0429448207 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2140,6 +2140,8 @@ static int spi_nor_sr2_bit1_quad_enable(struct spi_nor > *nor) if (nor->bouncebuf[0] & SR2_QUAD_EN_BIT1) > return 0; > > + nor->bouncebuf[0] |= SR2_QUAD_EN_BIT1; > + > return spi_nor_write_16bit_cr_and_check(nor, nor->bouncebuf[0]); > } > > -- > 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/