From: Jef Driesen <jef.driesen@niko.eu>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: richard@nod.at,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: ubifs: mounting fails due to error in orphan file handling
Date: Wed, 5 Feb 2020 16:25:26 +0100 [thread overview]
Message-ID: <21a266b9-ff3f-7a94-4562-11d6f59d4327@niko.eu> (raw)
In-Reply-To: <20200205092202.5f0929c3@xps13>
On 2/5/20 9:22 AM, Miquel Raynal wrote:
> "Driesen Jef (JDI)" <Jef.Driesen@niko.eu> wrote on Tue, 28
> Jan 2020 10:51:39 +0000:
>> ...
>>
>> I'm not really sure what's going on under the hood, but it looks like a
>> problem with the handling of the orphan files. With this knowledge, we
>> are now able to reproduce the problem reliable, by doing a power cut
>> while running the attached script. The scripts creates many files in a
>> loop, keeps them all open and removes them again. With this approach we
>> hit the problem about once every two attempts.
>>
>> The problem appeared for the first time after we switched from kernel
>> v4.7 to v5.3. I tried with v5.4 and master too, in case we are hitting a
>> problem that is already fixed, but they show the same problem. After
>> doing some bisecting, this commit appears to have introduced the problem:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/fs/ubifs/orphan.c?id=ee1438ce5dc4d67dd8dd1ff51583122a61f5bd9e
>>
>> How can we fix this?
>
> Just adding Richard into the loop, he is not available right now but
> will probably be interested by this issue. On my side, I have no clue :)
Thanks. If additional info is needed, or some extra testing is
necessary, just ask. I'm happy to help to get this fixed.
For now, we have reverted the above commit. That appears to work (e.g.
no more device that fail to boot), but I'm not convinced it's a good
long-term solution.
Jef
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-02-05 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 10:51 ubifs: mounting fails due to error in orphan file handling Driesen Jef (JDI)
2020-02-05 8:22 ` Miquel Raynal
2020-02-05 15:25 ` Jef Driesen [this message]
2020-02-05 16:17 ` Steve deRosier
2020-02-07 10:18 ` Jef Driesen
2020-02-07 11:04 ` Richard Weinberger
2020-02-11 13:47 ` Jef Driesen
2020-02-27 7:55 ` Richard Weinberger
2020-02-27 8:42 ` Jef Driesen
2020-02-27 8:51 ` Miquel Raynal
2020-02-27 9:07 ` Jef Driesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21a266b9-ff3f-7a94-4562-11d6f59d4327@niko.eu \
--to=jef.driesen@niko.eu \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).