From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>
Cc: "Michael Walle" <michael@walle.cc>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH dt-schema.git] schemas: add NVMEM cell with #nvmem-cell-cells
Date: Mon, 21 Nov 2022 12:25:39 +0100 [thread overview]
Message-ID: <259ad74e-ec86-34e6-661f-7b7b172c4ddd@linaro.org> (raw)
In-Reply-To: <20221121105830.7411-1-zajec5@gmail.com>
On 21/11/2022 11:58, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Some NVMEM cells may provide more than 1 value. An example can be base
> MAC address that is used for calculating multiple MACs (for few
> different devices). For specifying value to read phandle needs to be
> used with an argument.
>
> Cc: Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>
> Cc: Michael Walle <michael@walle.cc>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> This bit is required for moving forward with the
> [PATCH v2 00/20] nvmem: core: introduce NVMEM layouts
> https://lore.kernel.org/linux-arm-kernel/20220901221857.2600340-1-michael@walle.cc/
>
> As pointed out by Rob #nvmem-cell-cells should be added to the dt-schema
> and not a Linux binding:
> Re: [PATCH v2 15/20] dt-bindings: nvmem: add YAML schema for the sl28 vpd layout
> https://lore.kernel.org/linux-arm-kernel/20220912192038.GA1661550-robh@kernel.org/
>
> sl28 is one example that needs #nvmem-cell-cells
> u-boot,env is another one
>
> Please let me know if I got this binding right at all.
> ---
> dtschema/schemas/nvmem/nvmem-cell.yaml | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 dtschema/schemas/nvmem/nvmem-cell.yaml
>
> diff --git a/dtschema/schemas/nvmem/nvmem-cell.yaml b/dtschema/schemas/nvmem/nvmem-cell.yaml
> new file mode 100644
> index 0000000..dfa99b8
> --- /dev/null
> +++ b/dtschema/schemas/nvmem/nvmem-cell.yaml
> @@ -0,0 +1,23 @@
> +# SPDX-License-Identifier: BSD-2-Clause
> +$id: "http://devicetree.org/schemas/nvmem/nvmem-cell.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/base.yaml#"
Drop quotes from both.
> +
> +title: NVMEM Cell Common Properties
> +description: "Schema for NVMEM cell devicetree bindings"
Drop quotes.
> +maintainers:
> + - Rafał Miłecki <rafal@milecki.pl>
> + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> +
> +# always select the core schema
> +select: true
> +
> +properties:
> + "#nvmem-cell-cells":
> + $ref: "/schemas/types.yaml#/definitions/uint32"
Drop quotes.
Rest looks fine to me, except a bit funny cell-cell name, but that's
just life. :)
> + description: >
> + Some NVMEM cells may consist of raw data that requires some extra
> + processing. They may provide more than 1 value.
> +
> + Passing extra argument(s) allows selecting data to access.
> +
> +additionalProperties: true
Best regards,
Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-11-21 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 10:58 [PATCH dt-schema.git] schemas: add NVMEM cell with #nvmem-cell-cells Rafał Miłecki
2022-11-21 11:02 ` Michael Walle
2022-11-21 11:25 ` Krzysztof Kozlowski [this message]
2022-11-21 11:29 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=259ad74e-ec86-34e6-661f-7b7b172c4ddd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vigneshr@ti.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).